diff options
Diffstat (limited to 'lib/Driver')
-rw-r--r-- | lib/Driver/HTMLDiagnostics.cpp | 23 | ||||
-rw-r--r-- | lib/Driver/PlistDiagnostics.cpp | 15 | ||||
-rw-r--r-- | lib/Driver/TextDiagnosticPrinter.cpp | 4 |
3 files changed, 17 insertions, 25 deletions
diff --git a/lib/Driver/HTMLDiagnostics.cpp b/lib/Driver/HTMLDiagnostics.cpp index 81cedba557..2772cf3422 100644 --- a/lib/Driver/HTMLDiagnostics.cpp +++ b/lib/Driver/HTMLDiagnostics.cpp @@ -26,7 +26,6 @@ #include "llvm/Support/raw_ostream.h" #include "llvm/System/Path.h" #include <fstream> - using namespace clang; //===----------------------------------------------------------------------===// @@ -132,8 +131,8 @@ void HTMLDiagnostics::ReportDiag(const PathDiagnostic& D) { FullSourceLoc L = I->getLocation().getInstantiationLoc(); if (FID.isInvalid()) { - FID = SMgr.getCanonicalFileID(L); - } else if (SMgr.getCanonicalFileID(L) != FID) + FID = SMgr.getFileID(L); + } else if (SMgr.getFileID(L) != FID) return; // FIXME: Emit a warning? // Check the source ranges. @@ -142,19 +141,13 @@ void HTMLDiagnostics::ReportDiag(const PathDiagnostic& D) { SourceLocation L = SMgr.getInstantiationLoc(RI->getBegin()); - if (!L.isFileID()) - return; // FIXME: Emit a warning? - - if (SMgr.getCanonicalFileID(L) != FID) + if (!L.isFileID() || SMgr.getFileID(L) != FID) return; // FIXME: Emit a warning? L = SMgr.getInstantiationLoc(RI->getEnd()); - if (!L.isFileID()) + if (!L.isFileID() || SMgr.getFileID(L) != FID) return; // FIXME: Emit a warning? - - if (SMgr.getCanonicalFileID(L) != FID) - return; // FIXME: Emit a warning? } } @@ -336,10 +329,10 @@ void HTMLDiagnostics::HandlePiece(Rewriter& R, FileID BugFileID, SourceManager &SM = R.getSourceMgr(); FullSourceLoc LPos = Pos.getInstantiationLoc(); - FileID FID = SM.getCanonicalFileID(LPos); + FileID FID = SM.getFileID(LPos); assert(&LPos.getManager() == &SM && "SourceManagers are different!"); - if (SM.getCanonicalFileID(LPos) != BugFileID) + if (SM.getFileID(LPos) != BugFileID) return; const llvm::MemoryBuffer *Buf = SM.getBuffer(FID); @@ -469,8 +462,8 @@ void HTMLDiagnostics::HighlightRange(Rewriter& R, FileID BugFileID, if (EndLineNo < StartLineNo) return; - if (SM.getCanonicalFileID(InstantiationStart) != BugFileID || - SM.getCanonicalFileID(InstantiationEnd) != BugFileID) + if (SM.getFileID(InstantiationStart) != BugFileID || + SM.getFileID(InstantiationEnd) != BugFileID) return; // Compute the column number of the end. diff --git a/lib/Driver/PlistDiagnostics.cpp b/lib/Driver/PlistDiagnostics.cpp index 0b2ca52f11..9b7da48916 100644 --- a/lib/Driver/PlistDiagnostics.cpp +++ b/lib/Driver/PlistDiagnostics.cpp @@ -51,20 +51,18 @@ clang::CreatePlistDiagnosticClient(const std::string& s, return new PlistDiagnostics(s); } -static void AddFID(FIDMap &FIDs, - llvm::SmallVectorImpl<FileID> &V, +static void AddFID(FIDMap &FIDs, llvm::SmallVectorImpl<FileID> &V, SourceManager& SM, SourceLocation L) { - FileID FID = SM.getCanonicalFileID(SM.getInstantiationLoc(L)); + FileID FID = SM.getFileID(SM.getInstantiationLoc(L)); FIDMap::iterator I = FIDs.find(FID); if (I != FIDs.end()) return; FIDs[FID] = V.size(); V.push_back(FID); } -static unsigned GetFID(const FIDMap& FIDs, - SourceManager& SM, SourceLocation L) { - FileID FID = SM.getCanonicalFileID(SM.getInstantiationLoc(L)); +static unsigned GetFID(const FIDMap& FIDs, SourceManager& SM, SourceLocation L){ + FileID FID = SM.getFileID(SM.getInstantiationLoc(L)); FIDMap::const_iterator I = FIDs.find(FID); assert(I != FIDs.end()); return I->second; @@ -178,7 +176,7 @@ void PlistDiagnostics::HandlePathDiagnostic(const PathDiagnostic* D) { AddFID(FM, Fids, SM, I->getLocation()); for (PathDiagnosticPiece::range_iterator RI=I->ranges_begin(), - RE=I->ranges_end(); RI!=RE; ++RI) { + RE=I->ranges_end(); RI!=RE; ++RI) { AddFID(FM, Fids, SM, RI->getBegin()); AddFID(FM, Fids, SM, RI->getEnd()); } @@ -229,7 +227,8 @@ void PlistDiagnostics::HandlePathDiagnostic(const PathDiagnostic* D) { o << " </array>\n"; // Output the bug type and bug category. - o << " <key>description</key>\n <string>" << D->getDescription() << "</string>\n" + o << " <key>description</key>\n <string>" << D->getDescription() + << "</string>\n" " <key>category</key>\n <string>" << D->getCategory() << "</string>\n"; // Finish. diff --git a/lib/Driver/TextDiagnosticPrinter.cpp b/lib/Driver/TextDiagnosticPrinter.cpp index 4080b748ad..71a5e40107 100644 --- a/lib/Driver/TextDiagnosticPrinter.cpp +++ b/lib/Driver/TextDiagnosticPrinter.cpp @@ -48,13 +48,13 @@ void TextDiagnosticPrinter::HighlightRange(const SourceRange &R, SourceMgr.getInstantiationLoc(R.getBegin()); unsigned StartLineNo = SourceMgr.getLineNumber(InstantiationStart); if (StartLineNo > LineNo || - SourceMgr.getCanonicalFileID(InstantiationStart) != FID) + SourceMgr.getFileID(InstantiationStart) != FID) return; // No intersection. SourceLocation InstantiationEnd = SourceMgr.getInstantiationLoc(R.getEnd()); unsigned EndLineNo = SourceMgr.getLineNumber(InstantiationEnd); if (EndLineNo < LineNo || - SourceMgr.getCanonicalFileID(InstantiationEnd) != FID) + SourceMgr.getFileID(InstantiationEnd) != FID) return; // No intersection. // Compute the column number of the start. |