aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Sema/SemaExpr.cpp5
-rw-r--r--test/Sema/arg-duplicate.c15
2 files changed, 18 insertions, 2 deletions
diff --git a/Sema/SemaExpr.cpp b/Sema/SemaExpr.cpp
index bfb2d17143..fc4bc865cc 100644
--- a/Sema/SemaExpr.cpp
+++ b/Sema/SemaExpr.cpp
@@ -409,9 +409,10 @@ ParseCallExpr(ExprTy *fn, SourceLocation LParenLoc,
Fn->getSourceRange());
else if (NumArgsInCall > NumArgsInProto) {
if (!proto->isVariadic()) {
- Diag(Args[NumArgsInProto+1]->getLocStart(),
+ Diag(Args[NumArgsInProto]->getLocStart(),
diag::err_typecheck_call_too_many_args, Fn->getSourceRange(),
- Args[NumArgsInProto+1]->getSourceRange());
+ SourceRange(Args[NumArgsInProto]->getLocStart(),
+ Args[NumArgsInCall-1]->getLocEnd()));
}
NumArgsToCheck = NumArgsInProto;
}
diff --git a/test/Sema/arg-duplicate.c b/test/Sema/arg-duplicate.c
new file mode 100644
index 0000000000..5d44a72ecb
--- /dev/null
+++ b/test/Sema/arg-duplicate.c
@@ -0,0 +1,15 @@
+// RUN: clang -parse-ast-check %s
+
+typedef int x;
+int f3(y, x,
+ x) // expected-error {{redefinition of parameter}}
+ int y, x,
+ x; // expected-error {{redefinition of parameter}}
+{
+ return x + y;
+}
+
+void f4(void) {
+ f3 (1, 1, 2, 3, 4); // expected-error {{too many arguments to function}}
+}
+