diff options
-rw-r--r-- | include/clang/Basic/FileManager.h | 3 | ||||
-rw-r--r-- | lib/Basic/FileManager.cpp | 4 | ||||
-rw-r--r-- | lib/Tooling/Tooling.cpp | 1 | ||||
-rw-r--r-- | test/Tooling/Inputs/lit.local.cfg | 1 | ||||
-rw-r--r-- | test/Tooling/Inputs/pch-fail.h | 0 | ||||
-rw-r--r-- | test/Tooling/Inputs/pch.cpp | 0 | ||||
-rw-r--r-- | test/Tooling/Inputs/pch.h | 0 | ||||
-rw-r--r-- | test/Tooling/pch.cpp | 21 |
8 files changed, 30 insertions, 0 deletions
diff --git a/include/clang/Basic/FileManager.h b/include/clang/Basic/FileManager.h index 930523f4a7..b00f2b7827 100644 --- a/include/clang/Basic/FileManager.h +++ b/include/clang/Basic/FileManager.h @@ -186,6 +186,9 @@ public: /// \brief Removes the specified FileSystemStatCache object from the manager. void removeStatCache(FileSystemStatCache *statCache); + /// \brief Removes all FileSystemStatCache objects from the manager. + void clearStatCaches(); + /// \brief Lookup, cache, and verify the specified directory (real or /// virtual). /// diff --git a/lib/Basic/FileManager.cpp b/lib/Basic/FileManager.cpp index b921f3e0d9..c6b894c7e2 100644 --- a/lib/Basic/FileManager.cpp +++ b/lib/Basic/FileManager.cpp @@ -223,6 +223,10 @@ void FileManager::removeStatCache(FileSystemStatCache *statCache) { PrevCache->setNextStatCache(statCache->getNextStatCache()); } +void FileManager::clearStatCaches() { + StatCache.reset(0); +} + /// \brief Retrieve the directory that the given file name resides in. /// Filename can point to either a real file or a virtual file. static const DirectoryEntry *getDirectoryFromFile(FileManager &FileMgr, diff --git a/lib/Tooling/Tooling.cpp b/lib/Tooling/Tooling.cpp index 5d41172a91..e93e0c97f7 100644 --- a/lib/Tooling/Tooling.cpp +++ b/lib/Tooling/Tooling.cpp @@ -212,6 +212,7 @@ bool ToolInvocation::runInvocation( const bool Success = Compiler.ExecuteAction(*ScopedToolAction); Compiler.resetAndLeakFileManager(); + Files->clearStatCaches(); return Success; } diff --git a/test/Tooling/Inputs/lit.local.cfg b/test/Tooling/Inputs/lit.local.cfg new file mode 100644 index 0000000000..e6f55eef7a --- /dev/null +++ b/test/Tooling/Inputs/lit.local.cfg @@ -0,0 +1 @@ +config.suffixes = [] diff --git a/test/Tooling/Inputs/pch-fail.h b/test/Tooling/Inputs/pch-fail.h new file mode 100644 index 0000000000..e69de29bb2 --- /dev/null +++ b/test/Tooling/Inputs/pch-fail.h diff --git a/test/Tooling/Inputs/pch.cpp b/test/Tooling/Inputs/pch.cpp new file mode 100644 index 0000000000..e69de29bb2 --- /dev/null +++ b/test/Tooling/Inputs/pch.cpp diff --git a/test/Tooling/Inputs/pch.h b/test/Tooling/Inputs/pch.h new file mode 100644 index 0000000000..e69de29bb2 --- /dev/null +++ b/test/Tooling/Inputs/pch.h diff --git a/test/Tooling/pch.cpp b/test/Tooling/pch.cpp new file mode 100644 index 0000000000..bfa20d806b --- /dev/null +++ b/test/Tooling/pch.cpp @@ -0,0 +1,21 @@ +// This is a regression test for handling of stat caches within the tooling +// infrastructure. This test reproduces the problem under valgrind: + +// First, create a pch that we can later load. Loading the pch will insert +// a stat cache into the FileManager: +// RUN: %clang -x c++-header %S/Inputs/pch.h -o %t1 + +// Use the generated pch and enforce a subsequent stat miss by by using +// the test file with an unrelated include as second translation unit: +// Do not directly pipe into FileCheck, as that would hide errors from +// valgrind due to pipefail not being set in lit. +// RUN: clang-check "%S/Inputs/pch.cpp" "%s" -- -include-pch %t1 -I "%S" -c >%t2 2>&1 +// RUN: FileCheck %s < %t2 + +#include "Inputs/pch-fail.h" + +// CHECK: Processing + +// FIXME: This is incompatible to -fms-compatibility. +// XFAIL: win32 + |