diff options
| -rw-r--r-- | lib/Sema/SemaChecking.cpp | 7 | ||||
| -rw-r--r-- | test/Sema/format-strings.c | 7 |
2 files changed, 14 insertions, 0 deletions
diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp index 6092348004..1a7bd1d07f 100644 --- a/lib/Sema/SemaChecking.cpp +++ b/lib/Sema/SemaChecking.cpp @@ -955,6 +955,13 @@ bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, format_idx, firstDataArg, isPrintf); } + case Stmt::IntegerLiteralClass: + // Technically -Wformat-nonliteral does not warn about this case. + // The behavior of printf and friends in this case is implementation + // dependent. Ideally if the format string cannot be null then + // it should have a 'nonnull' attribute in the function prototype. + return true; + case Stmt::ImplicitCastExprClass: { E = cast<ImplicitCastExpr>(E)->getSubExpr(); goto tryAgain; diff --git a/test/Sema/format-strings.c b/test/Sema/format-strings.c index 2325454c0b..9e8007b9b0 100644 --- a/test/Sema/format-strings.c +++ b/test/Sema/format-strings.c @@ -301,3 +301,10 @@ void pr7981(wint_t c, wchar_t c2) { printf("%lc", c2); // no-warning } +// <rdar://problem/8269537> -Wformat-security says NULL is not a string literal +void r8269537() { + // This is likely to crash in most cases, but -Wformat-nonliteral technically + // doesn't warn in this case. + printf(0); // no-warning +} + |