diff options
| -rw-r--r-- | lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp | 30 | ||||
| -rw-r--r-- | test/Analysis/retain-release.m | 20 |
2 files changed, 50 insertions, 0 deletions
diff --git a/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp b/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp index a59d1e4e4c..a5146b7cb2 100644 --- a/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp @@ -1192,6 +1192,36 @@ RetainSummaryManager::updateSummaryFromAnnotations(const RetainSummary *&Summ, return; RetainSummaryTemplate Template(Summ, DefaultSummary, *this); + + // Check the method family, and apply any default annotations. + switch (MD->getMethodFamily()) { + case OMF_None: + break; + case OMF_init: + Template->setRetEffect(ObjCInitRetE); + Template->setReceiverEffect(DecRefMsg); + break; + case OMF_alloc: + case OMF_new: + case OMF_copy: + case OMF_mutableCopy: + Template->setRetEffect(ObjCAllocRetE); + break; + case OMF_autorelease: + Template->setReceiverEffect(Autorelease); + case OMF_retain: + Template->setReceiverEffect(IncRefMsg); + break; + case OMF_release: + Template->setReceiverEffect(DecRefMsg); + break; + case OMF_self: + case OMF_performSelector: + case OMF_retainCount: + case OMF_dealloc: + case OMF_finalize: + break; + } bool isTrackedLoc = false; diff --git a/test/Analysis/retain-release.m b/test/Analysis/retain-release.m index 548564fe4c..8b0e7b83a7 100644 --- a/test/Analysis/retain-release.m +++ b/test/Analysis/retain-release.m @@ -1647,6 +1647,26 @@ void rdar9658496() { xpc_release(xpc); } +// Support annotations with method families. +@interface RDar10824732 : NSObject +- (id)initWithObj:(id CF_CONSUMED)obj; +@end + +@implementation RDar10824732 +- (id)initWithObj:(id)obj { + [obj release]; + return [super init]; +} +@end + +void rdar_10824732() { + @autoreleasepool { + NSString *obj = @"test"; + RDar10824732 *foo = [[RDar10824732 alloc] initWithObj:obj]; // no-warning + [foo release]; + } +} + //===----------------------------------------------------------------------===// // ObjC literals support. //===----------------------------------------------------------------------===// |