diff options
| -rw-r--r-- | lib/Analysis/GRExprEngine.cpp | 2 | ||||
| -rw-r--r-- | test/Analysis/misc-ps.m | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/lib/Analysis/GRExprEngine.cpp b/lib/Analysis/GRExprEngine.cpp index a6c3c66a0a..735949cd4a 100644 --- a/lib/Analysis/GRExprEngine.cpp +++ b/lib/Analysis/GRExprEngine.cpp @@ -1006,7 +1006,7 @@ void GRExprEngine::VisitDeclRefExpr(DeclRefExpr *Ex, ExplodedNode *Pred, return; } else if (const FunctionDecl* FD = dyn_cast<FunctionDecl>(D)) { - assert(asLValue); + // This code is valid regardless of the value of 'isLValue'. SVal V = ValMgr.getFunctionPointer(FD); MakeNode(Dst, Ex, Pred, state->BindExpr(Ex, V), ProgramPoint::PostLValueKind); diff --git a/test/Analysis/misc-ps.m b/test/Analysis/misc-ps.m index f877d4449c..9c27029d66 100644 --- a/test/Analysis/misc-ps.m +++ b/test/Analysis/misc-ps.m @@ -650,3 +650,10 @@ CGFloat rdar7242006(CGFloat x) { return y.width; // no-warning } +// PR 4988 - This test exhibits a case where a function can be referenced +// when not explicitly used in an "lvalue" context (as far as the analyzer is +// concerned). This previously triggered a crash due to an invalid assertion. +void pr_4988(void) { + pr_4988; // expected-warning{{expression result unused}} +} + |