diff options
-rw-r--r-- | include/clang/Driver/ArgList.h | 32 | ||||
-rw-r--r-- | lib/Driver/ArgList.cpp | 16 |
2 files changed, 32 insertions, 16 deletions
diff --git a/include/clang/Driver/ArgList.h b/include/clang/Driver/ArgList.h index f4ab57e059..06c434c022 100644 --- a/include/clang/Driver/ArgList.h +++ b/include/clang/Driver/ArgList.h @@ -35,14 +35,22 @@ namespace driver { private: /// List of argument strings used by the contained Args. - ArgStringList ArgStrings; + /// + /// This is mutable since we treat the ArgList as being the list + /// of Args, and allow routines to add new strings (to have a + /// convenient place to store the memory) via MakeIndex. + mutable ArgStringList ArgStrings; + + /// Strings for synthesized arguments. + /// + /// This is mutable since we treat the ArgList as being the list + /// of Args, and allow routines to add new strings (to have a + /// convenient place to store the memory) via MakeIndex. + mutable std::list<std::string> SynthesizedStrings; /// The full list of arguments. arglist_type Args; - /// Strings for synthesized arguments. - std::list<std::string> SynthesizedStrings; - public: ArgList(const char **ArgBegin, const char **ArgEnd); ArgList(const ArgList &); @@ -79,25 +87,29 @@ namespace driver { private: /// MakeIndex - Get an index for the given string(s). - unsigned MakeIndex(const char *String0); - unsigned MakeIndex(const char *String0, const char *String1); + unsigned MakeIndex(const char *String0) const; + unsigned MakeIndex(const char *String0, const char *String1) const; public: + /// MakeArgString - Construct a constant string pointer whose + /// lifetime will match that of the ArgList. + const char *MakeArgString(const char *Str) const; + /// MakeFlagArg - Construct a new FlagArg for the given option /// \arg Id. - Arg *MakeFlagArg(const Option *Opt); + Arg *MakeFlagArg(const Option *Opt) const; /// MakePositionalArg - Construct a new Positional arg for the /// given option \arg Id, with the provided \arg Value. - Arg *MakePositionalArg(const Option *Opt, const char *Value); + Arg *MakePositionalArg(const Option *Opt, const char *Value) const; /// MakeSeparateArg - Construct a new Positional arg for the /// given option \arg Id, with the provided \arg Value. - Arg *MakeSeparateArg(const Option *Opt, const char *Value); + Arg *MakeSeparateArg(const Option *Opt, const char *Value) const; /// MakeJoinedArg - Construct a new Positional arg for the /// given option \arg Id, with the provided \arg Value. - Arg *MakeJoinedArg(const Option *Opt, const char *Value); + Arg *MakeJoinedArg(const Option *Opt, const char *Value) const; /// @} }; diff --git a/lib/Driver/ArgList.cpp b/lib/Driver/ArgList.cpp index d32d9f2185..66fcb70885 100644 --- a/lib/Driver/ArgList.cpp +++ b/lib/Driver/ArgList.cpp @@ -44,7 +44,7 @@ Arg *ArgList::getLastArg(options::ID Id, bool Claim) const { return 0; } -unsigned ArgList::MakeIndex(const char *String0) { +unsigned ArgList::MakeIndex(const char *String0) const { unsigned Index = ArgStrings.size(); // Tuck away so we have a reliable const char *. @@ -54,7 +54,7 @@ unsigned ArgList::MakeIndex(const char *String0) { return Index; } -unsigned ArgList::MakeIndex(const char *String0, const char *String1) { +unsigned ArgList::MakeIndex(const char *String0, const char *String1) const { unsigned Index0 = MakeIndex(String0); unsigned Index1 = MakeIndex(String1); assert(Index0 + 1 == Index1 && "Unexpected non-consecutive indices!"); @@ -62,19 +62,23 @@ unsigned ArgList::MakeIndex(const char *String0, const char *String1) { return Index0; } -Arg *ArgList::MakeFlagArg(const Option *Opt) { +const char *ArgList::MakeArgString(const char *Str) const { + return getArgString(MakeIndex(Str)); +} + +Arg *ArgList::MakeFlagArg(const Option *Opt) const { return new FlagArg(Opt, MakeIndex(Opt->getName())); } -Arg *ArgList::MakePositionalArg(const Option *Opt, const char *Value) { +Arg *ArgList::MakePositionalArg(const Option *Opt, const char *Value) const { return new PositionalArg(Opt, MakeIndex(Value)); } -Arg *ArgList::MakeSeparateArg(const Option *Opt, const char *Value) { +Arg *ArgList::MakeSeparateArg(const Option *Opt, const char *Value) const { return new SeparateArg(Opt, MakeIndex(Opt->getName(), Value), 1); } -Arg *ArgList::MakeJoinedArg(const Option *Opt, const char *Value) { +Arg *ArgList::MakeJoinedArg(const Option *Opt, const char *Value) const { std::string Joined(Opt->getName()); Joined += Value; return new JoinedArg(Opt, MakeIndex(Joined.c_str())); |