aboutsummaryrefslogtreecommitdiff
path: root/unittests/Format/FormatTest.cpp
diff options
context:
space:
mode:
authorNico Weber <nicolasweber@gmx.de>2013-01-10 21:30:42 +0000
committerNico Weber <nicolasweber@gmx.de>2013-01-10 21:30:42 +0000
commit7084823f8ec4367019940b26245e01684b62c7e1 (patch)
tree77181246daae0f425cc9b16e953dee250816c587 /unittests/Format/FormatTest.cpp
parentb1fc673783dd0215a1426b2c411779cd05a16a07 (diff)
Formatter: No spaces around '=' in @property lines.
Before: @property(assign, getter = isEditable) BOOL editable; Now: @property(assign, getter=isEditable) BOOL editable; It'd be nice if some Apple person could let me know if spaces are preferred around '=' in @synthesize lines (see FIXME in the test). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@172110 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests/Format/FormatTest.cpp')
-rw-r--r--unittests/Format/FormatTest.cpp9
1 files changed, 7 insertions, 2 deletions
diff --git a/unittests/Format/FormatTest.cpp b/unittests/Format/FormatTest.cpp
index 5844853e05..deb668d984 100644
--- a/unittests/Format/FormatTest.cpp
+++ b/unittests/Format/FormatTest.cpp
@@ -1430,7 +1430,6 @@ TEST_F(FormatTest, ObjCAt) {
verifyFormat("@[");
verifyFormat("@{");
-
EXPECT_EQ("@interface", format("@ interface"));
// The precise formatting of this doesn't matter, nobody writes code like
@@ -1452,10 +1451,16 @@ TEST_F(FormatTest, ObjCSnippets) {
verifyFormat("@synchronized(self) {\n"
" f();\n"
"}");
+
+ // FIXME: Some Apple code examples don't have spaces around '=' for
+ // @synthesize, decide if that's desired or not in LLVM style. Google style
+ // definitely wants spaces.
verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;");
+ verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;");
- // FIXME: "getter=bar" should not be surround by spaces in @property.
verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;");
+ verifyFormat("@property(assign, getter=isEditable) BOOL editable;");
+ verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;");
}
} // end namespace tooling