diff options
| author | David Blaikie <dblaikie@gmail.com> | 2012-04-02 19:15:28 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2012-04-02 19:15:28 +0000 |
| commit | 460ef136eb96b879f149c8703938a13c35b4bc68 (patch) | |
| tree | e43369d9349e529c2472ce39949b9378302675ec /test/FixIt/fixit.cpp | |
| parent | e7d0bbfa101d0f0b955c04c417b5e3283497a7ed (diff) | |
Correct error recovery when missing 'class' in a template template parameter.
The diagnostic message correctly informs the user that they have omitted the
'class' keyword, but neither suggests this insertion as a fixit, nor attempts
to recover as if they had provided the keyword.
This fixes the recovery, adds the fixit, and adds a separate diagnostic and
corresponding replacement fixit for cases where the user wrote 'struct' or
'typename' instead of 'class' (suggested by Richard Smith as a possible common
mistake).
I'm not sure the diagnostic message for either the original or new cases feel
very Clang-esque, so I'm open to suggestions there. The fixit hints make it
fairly easy to see what's required, though.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@153887 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/FixIt/fixit.cpp')
| -rw-r--r-- | test/FixIt/fixit.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/test/FixIt/fixit.cpp b/test/FixIt/fixit.cpp index 9ed4f3b0cf..c881c63e6b 100644 --- a/test/FixIt/fixit.cpp +++ b/test/FixIt/fixit.cpp @@ -199,3 +199,8 @@ template<class T> typedef Mystery<T>::type getMysteriousThing() { // \ expected-error {{missing 'typename' prior to dependent}} return Mystery<T>::get(); } + +template<template<typename> Foo, // expected-error {{expected 'class' before 'Foo'}} + template<typename> typename Bar, // expected-error {{expected 'class' instead of 'typename'}} + template<typename> struct Baz> // expected-error {{expected 'class' instead of 'struct'}} +void func(); |