diff options
author | Richard Smith <richard-llvm@metafoo.co.uk> | 2012-04-25 23:23:48 +0000 |
---|---|---|
committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2012-04-25 23:23:48 +0000 |
commit | c799a6a5c884831c3c3ea57d30fbe4ab35709d49 (patch) | |
tree | e7bce1263f1ed2958ac7f8c224c60ebf50ac76c3 /lib/Sema/SemaType.cpp | |
parent | a313b2fbba86c901e58dc58df036e731f24fdaee (diff) |
If a type is non-literal by virtue of being incomplete produce notes
explaining that.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155598 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaType.cpp')
-rw-r--r-- | lib/Sema/SemaType.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/lib/Sema/SemaType.cpp b/lib/Sema/SemaType.cpp index 1b95f05c79..8b237c8a3c 100644 --- a/lib/Sema/SemaType.cpp +++ b/lib/Sema/SemaType.cpp @@ -4301,9 +4301,14 @@ bool Sema::RequireLiteralType(SourceLocation Loc, QualType T, const CXXRecordDecl *RD = cast<CXXRecordDecl>(RT->getDecl()); - // FIXME: Better diagnostic for incomplete class? - if (!RD->isCompleteDefinition()) + // A partially-defined class type can't be a literal type, because a literal + // class type must have a trivial destructor (which can't be checked until + // the class definition is complete). + if (!RD->isCompleteDefinition()) { + RequireCompleteType(Loc, ElemType, + PDiag(diag::note_non_literal_incomplete) << T); return true; + } // If the class has virtual base classes, then it's not an aggregate, and // cannot have any constexpr constructors or a trivial default constructor, |