aboutsummaryrefslogtreecommitdiff
path: root/lib/Sema/SemaExpr.cpp
diff options
context:
space:
mode:
authorRichard Trieu <rtrieu@google.com>2011-09-06 18:38:41 +0000
committerRichard Trieu <rtrieu@google.com>2011-09-06 18:38:41 +0000
commit8ef5c8ef41b8578ac754815c57728c3a3e6b422c (patch)
treee1ad9ab8e6737936d4e9005c41a3fde9cd197917 /lib/Sema/SemaExpr.cpp
parentcafd30b4cd2f1a18baecb0ae7dc5f2351b8b8bcb (diff)
Rename variables in SemaExpr.cpp to give a more consistant naming scheme.
ExprResult LHS, RHS, Expr *LHSExpr, *RHSExpr QualType LHSType, RHSType Functions changed: handleFloatConversion() handleComplexIntConvsersion() git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@139153 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaExpr.cpp')
-rw-r--r--lib/Sema/SemaExpr.cpp67
1 files changed, 32 insertions, 35 deletions
diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index 16b6f44721..44a82c0aa3 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -708,33 +708,33 @@ static QualType handleIntToFloatConversion(Sema &S, ExprResult &floatExpr,
/// \brief Handle arithmethic conversion with floating point types. Helper
/// function of UsualArithmeticConversions()
-static QualType handleFloatConversion(Sema &S, ExprResult &lhsExpr,
- ExprResult &rhsExpr, QualType lhs,
- QualType rhs, bool isCompAssign) {
- bool LHSFloat = lhs->isRealFloatingType();
- bool RHSFloat = rhs->isRealFloatingType();
+static QualType handleFloatConversion(Sema &S, ExprResult &LHS,
+ ExprResult &RHS, QualType LHSType,
+ QualType RHSType, bool isCompAssign) {
+ bool LHSFloat = LHSType->isRealFloatingType();
+ bool RHSFloat = RHSType->isRealFloatingType();
// If we have two real floating types, convert the smaller operand
// to the bigger result.
if (LHSFloat && RHSFloat) {
- int order = S.Context.getFloatingTypeOrder(lhs, rhs);
+ int order = S.Context.getFloatingTypeOrder(LHSType, RHSType);
if (order > 0) {
- rhsExpr = S.ImpCastExprToType(rhsExpr.take(), lhs, CK_FloatingCast);
- return lhs;
+ RHS = S.ImpCastExprToType(RHS.take(), LHSType, CK_FloatingCast);
+ return LHSType;
}
assert(order < 0 && "illegal float comparison");
if (!isCompAssign)
- lhsExpr = S.ImpCastExprToType(lhsExpr.take(), rhs, CK_FloatingCast);
- return rhs;
+ LHS = S.ImpCastExprToType(LHS.take(), RHSType, CK_FloatingCast);
+ return RHSType;
}
if (LHSFloat)
- return handleIntToFloatConversion(S, lhsExpr, rhsExpr, lhs, rhs,
+ return handleIntToFloatConversion(S, LHS, RHS, LHSType, RHSType,
/*convertFloat=*/!isCompAssign,
/*convertInt=*/ true);
assert(RHSFloat);
- return handleIntToFloatConversion(S, rhsExpr, lhsExpr, rhs, lhs,
+ return handleIntToFloatConversion(S, RHS, LHS, RHSType, LHSType,
/*convertInt=*/ true,
/*convertFloat=*/!isCompAssign);
}
@@ -743,42 +743,39 @@ static QualType handleFloatConversion(Sema &S, ExprResult &lhsExpr,
/// of UsualArithmeticConverions()
// FIXME: if the operands are (int, _Complex long), we currently
// don't promote the complex. Also, signedness?
-static QualType handleComplexIntConvsersion(Sema &S, ExprResult &lhsExpr,
- ExprResult &rhsExpr, QualType lhs,
- QualType rhs, bool isCompAssign) {
- const ComplexType *lhsComplexInt = lhs->getAsComplexIntegerType();
- const ComplexType *rhsComplexInt = rhs->getAsComplexIntegerType();
-
- if (lhsComplexInt && rhsComplexInt) {
- int order = S.Context.getIntegerTypeOrder(lhsComplexInt->getElementType(),
- rhsComplexInt->getElementType());
+static QualType handleComplexIntConvsersion(Sema &S, ExprResult &LHS,
+ ExprResult &RHS, QualType LHSType,
+ QualType RHSType,
+ bool isCompAssign) {
+ const ComplexType *LHSComplexInt = LHSType->getAsComplexIntegerType();
+ const ComplexType *RHSComplexInt = RHSType->getAsComplexIntegerType();
+
+ if (LHSComplexInt && RHSComplexInt) {
+ int order = S.Context.getIntegerTypeOrder(LHSComplexInt->getElementType(),
+ RHSComplexInt->getElementType());
assert(order && "inequal types with equal element ordering");
if (order > 0) {
// _Complex int -> _Complex long
- rhsExpr = S.ImpCastExprToType(rhsExpr.take(), lhs,
- CK_IntegralComplexCast);
- return lhs;
+ RHS = S.ImpCastExprToType(RHS.take(), LHSType, CK_IntegralComplexCast);
+ return LHSType;
}
if (!isCompAssign)
- lhsExpr = S.ImpCastExprToType(lhsExpr.take(), rhs,
- CK_IntegralComplexCast);
- return rhs;
+ LHS = S.ImpCastExprToType(LHS.take(), RHSType, CK_IntegralComplexCast);
+ return RHSType;
}
- if (lhsComplexInt) {
+ if (LHSComplexInt) {
// int -> _Complex int
- rhsExpr = S.ImpCastExprToType(rhsExpr.take(), lhs,
- CK_IntegralRealToComplex);
- return lhs;
+ RHS = S.ImpCastExprToType(RHS.take(), LHSType, CK_IntegralRealToComplex);
+ return LHSType;
}
- assert(rhsComplexInt);
+ assert(RHSComplexInt);
// int -> _Complex int
if (!isCompAssign)
- lhsExpr = S.ImpCastExprToType(lhsExpr.take(), rhs,
- CK_IntegralRealToComplex);
- return rhs;
+ LHS = S.ImpCastExprToType(LHS.take(), RHSType, CK_IntegralRealToComplex);
+ return RHSType;
}
/// \brief Handle integer arithmetic conversions. Helper function of