diff options
| author | Chris Lattner <sabre@nondot.org> | 2011-08-02 21:44:23 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2011-08-02 21:44:23 +0000 |
| commit | 9e6a1caf18565849cc7bec265bcb0b8af4e1d93a (patch) | |
| tree | fe47a898ffd937a30b419e2c59f8ebc583d3da9f /lib/Sema/SemaChecking.cpp | |
| parent | fc6142779f42058b4a39a29b6209a01a6de9fe7c (diff) | |
disable array bounds overflow warning for cases where an array
has a single element. This disables the warning in cases where
there is a clear bug, but this is really rare (who uses arrays
with one element?) and it also silences a large class of false
positive issues with C89 code that is using tail padding in structs.
A better version of this patch would detect when an array is in
a tail position in a struct, but at least patch fixes the huge
false positives that are hitting postgres and other code.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@136724 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaChecking.cpp')
| -rw-r--r-- | lib/Sema/SemaChecking.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp index 28085ef6ea..81ae7b3afb 100644 --- a/lib/Sema/SemaChecking.cpp +++ b/lib/Sema/SemaChecking.cpp @@ -3491,7 +3491,9 @@ static void CheckArrayAccess_Check(Sema &S, else if (size.getBitWidth() < index.getBitWidth()) size = size.sext(index.getBitWidth()); - if (index.slt(size)) + // Don't warn for valid indexes, or arrays of size 1 (which are often + // tail-allocated arrays that are emulating flexible arrays in C89 code). + if (index.slt(size) || size == 1) return; S.DiagRuntimeBehavior(E->getBase()->getLocStart(), BaseExpr, |