diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2011-06-16 02:00:04 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2011-06-16 02:00:04 +0000 |
| commit | 5546e69729b9f195afd0410948e013206618b717 (patch) | |
| tree | 9cff50aed75fb580ba4714d294662ae58ed892bf /lib/Sema/SemaChecking.cpp | |
| parent | 62c37119940e76b8b8923d99551a779e686f9d2f (diff) | |
Skip both character pointers and void pointers when diagnosing bad
argument types for mem{set,cpy,move}. Character pointers, much like void
pointers, often point to generic "memory", so trying to check whether
they match the type of the argument to 'sizeof' (or other checks) is
unproductive and often results in false positives.
Nico, please review; does this miss any of the bugs you were trying to
find with this warning? The array test case you had should be caught by
the array-specific sizeof warning I think.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@133136 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaChecking.cpp')
| -rw-r--r-- | lib/Sema/SemaChecking.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp index d45ebf9033..945964fc35 100644 --- a/lib/Sema/SemaChecking.cpp +++ b/lib/Sema/SemaChecking.cpp @@ -1866,7 +1866,9 @@ void Sema::CheckMemsetcpymoveArguments(const CallExpr *Call, if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { QualType PointeeTy = DestPtrTy->getPointeeType(); - if (PointeeTy->isVoidType()) + // Don't warn about void pointers or char pointers as both are often used + // for directly representing memory, regardless of its underlying type. + if (PointeeTy->isVoidType() || PointeeTy->isCharType()) continue; // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). |