aboutsummaryrefslogtreecommitdiff
path: root/lib/Frontend
diff options
context:
space:
mode:
authorChad Rosier <mcrosier@apple.com>2011-11-15 18:57:32 +0000
committerChad Rosier <mcrosier@apple.com>2011-11-15 18:57:32 +0000
commit496cc8eae2c69b8fd36a2b3e815dd0e8207ec493 (patch)
treef05dac46a2caed10667292ff4d6e5824f10d6b1f /lib/Frontend
parent2d9eb21325a0854e86de7344f54a8e6cef2a97ad (diff)
Fix a regression from 143657. The second pass of the warning options should only be emitting
warnings/errors for unknown warning options. getDiagnosticsInGroup returns false if the diagnostics is found and true otherwise. Thus, if we're reporting and we have a valid diagnostic, we were actually setting the flag and causing mayhem. rdar://10444207 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@144670 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Frontend')
-rw-r--r--lib/Frontend/Warnings.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/Frontend/Warnings.cpp b/lib/Frontend/Warnings.cpp
index 4e41e22138..3588af0d4a 100644
--- a/lib/Frontend/Warnings.cpp
+++ b/lib/Frontend/Warnings.cpp
@@ -166,8 +166,9 @@ void clang::ProcessWarningOptions(DiagnosticsEngine &Diags,
continue;
}
- if (Report && DiagIDs->getDiagnosticsInGroup(Opt, _Diags)) {
- EmitUnkownDiagWarning(Diags, "-W", Opt, isPositive);
+ if (Report) {
+ if (DiagIDs->getDiagnosticsInGroup(Opt, _Diags))
+ EmitUnkownDiagWarning(Diags, "-W", Opt, isPositive);
} else {
Diags.setDiagnosticGroupMapping(Opt, Mapping);
}