diff options
author | Ted Kremenek <kremenek@apple.com> | 2009-10-23 04:45:31 +0000 |
---|---|---|
committer | Ted Kremenek <kremenek@apple.com> | 2009-10-23 04:45:31 +0000 |
commit | 231bc0b7a7f53ce0d1af85602232486bc92c5a34 (patch) | |
tree | 25fbf33579a25d3508e1aae8eb8fb79409221e93 /lib/Frontend/PCHReader.cpp | |
parent | ff1ea462bf6f079a786c600d5fc3716235ad9f22 (diff) |
Add comment.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@84930 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Frontend/PCHReader.cpp')
-rw-r--r-- | lib/Frontend/PCHReader.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/Frontend/PCHReader.cpp b/lib/Frontend/PCHReader.cpp index d4302f44c8..9c6059b1c7 100644 --- a/lib/Frontend/PCHReader.cpp +++ b/lib/Frontend/PCHReader.cpp @@ -2515,6 +2515,9 @@ IdentifierInfo *PCHReader::DecodeIdentifierInfo(unsigned ID) { // All of the strings in the PCH file are preceded by a 16-bit // length. Extract that 16-bit length to avoid having to execute // strlen(). + // NOTE: 'StrLenPtr' is an 'unsigned char*' so that we load bytes as + // unsigned integers. This is important to avoid integer overflow when + // we cast them to 'unsigned'. const unsigned char *StrLenPtr = (const unsigned char*) Str - 2; unsigned StrLen = (((unsigned) StrLenPtr[0]) | (((unsigned) StrLenPtr[1]) << 8)) - 1; |