diff options
author | Eli Friedman <eli.friedman@gmail.com> | 2009-04-20 03:54:15 +0000 |
---|---|---|
committer | Eli Friedman <eli.friedman@gmail.com> | 2009-04-20 03:54:15 +0000 |
commit | c62aad8f45ec3dd893376bd1c51e5e8019a76d8e (patch) | |
tree | b321cc7409b507e63baaf82366b7ad4ddebcf3f8 /lib/CodeGen | |
parent | 8f426fa9fca022201fc0944d6c1cb2cf9918db7d (diff) |
PR3247: Handle a couple of cases where we weren't emitting VLA sizes (and
subsequently crashed).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@69567 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen')
-rw-r--r-- | lib/CodeGen/CGDecl.cpp | 4 | ||||
-rw-r--r-- | lib/CodeGen/CGExprScalar.cpp | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/lib/CodeGen/CGDecl.cpp b/lib/CodeGen/CGDecl.cpp index 681d8f68af..0a1d1d0bd1 100644 --- a/lib/CodeGen/CGDecl.cpp +++ b/lib/CodeGen/CGDecl.cpp @@ -122,6 +122,10 @@ void CodeGenFunction::EmitStaticBlockVarDecl(const VarDecl &D) { // circular references. DMEntry = GV; + // Make sure to evaluate VLA bounds now so that we have them for later. + if (D.getType()->isVariablyModifiedType()) + EmitVLASize(D.getType()); + if (D.getInit()) { llvm::Constant *Init = CGM.EmitConstantExpr(D.getInit(), D.getType(), this); diff --git a/lib/CodeGen/CGExprScalar.cpp b/lib/CodeGen/CGExprScalar.cpp index 0c6e6c6854..77771bd937 100644 --- a/lib/CodeGen/CGExprScalar.cpp +++ b/lib/CodeGen/CGExprScalar.cpp @@ -213,7 +213,11 @@ public: return llvm::Constant::getNullValue(ConvertType(E->getType())); } Value *VisitImplicitCastExpr(const ImplicitCastExpr *E); - Value *VisitCastExpr(const CastExpr *E) { + Value *VisitCastExpr(const CastExpr *E) { + // Make sure to evaluate VLA bounds now so that we have them for later. + if (E->getType()->isVariablyModifiedType()) + CGF.EmitVLASize(E->getType()); + return EmitCastExpr(E->getSubExpr(), E->getType()); } Value *EmitCastExpr(const Expr *E, QualType T); |