Visibility attributes should only be set on definition.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68561 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 6 insertions, 4 deletions

diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp
index 1dd2c4d67f..508d7ce2b6 100644
--- a/lib/CodeGen/CodeGenModule.cpp
+++ b/lib/CodeGen/CodeGenModule.cpp
@@ -272,10 +272,12 @@ void CodeGenModule::SetGlobalValueAttributes(const Decl *D,
 
   // FIXME: Figure out the relative priority of the attribute,
   // -fvisibility, and private_extern.
-  if (const VisibilityAttr *attr = D->getAttr<VisibilityAttr>())
-    setGlobalVisibility(GV, attr->getVisibility());
-  else
-    setGlobalOptionVisibility(GV, getLangOptions().getVisibilityMode());
+  if (ForDefinition) {
+    if (const VisibilityAttr *attr = D->getAttr<VisibilityAttr>())
+      setGlobalVisibility(GV, attr->getVisibility());
+    else
+      setGlobalOptionVisibility(GV, getLangOptions().getVisibilityMode());
+  }
 
   if (const SectionAttr *SA = D->getAttr<SectionAttr>())
     GV->setSection(SA->getName());