diff options
| author | John McCall <rjmccall@apple.com> | 2010-05-25 04:30:21 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2010-05-25 04:30:21 +0000 |
| commit | 8b2423361648c39a7d8a3c5e8129e12006deac32 (patch) | |
| tree | 8113ac1969dd99513a97a8c1d09d5aa00de67642 /lib/CodeGen/CodeGenModule.h | |
| parent | 45806fe5b89de739af95bea2e0d1a5822d53ae9b (diff) | |
If a function definition has any sort of weak linkage, its static local
variables should have that linkage. Otherwise, its static local
variables should have internal linkage. To avoid computing this excessively,
set a function's linkage before we emit code for it.
Previously we were assigning weak linkage to the static variables of
static inline functions in C++, with predictably terrible results. This
fixes that and also gives better linkage than 'weak' when merging is required.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@104581 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CodeGenModule.h')
| -rw-r--r-- | lib/CodeGen/CodeGenModule.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/CodeGen/CodeGenModule.h b/lib/CodeGen/CodeGenModule.h index 0e4f4a932e..e225462fac 100644 --- a/lib/CodeGen/CodeGenModule.h +++ b/lib/CodeGen/CodeGenModule.h @@ -436,6 +436,10 @@ public: llvm::GlobalVariable::LinkageTypes getFunctionLinkage(const FunctionDecl *FD); + void setFunctionLinkage(const FunctionDecl *FD, llvm::GlobalValue *V) { + V->setLinkage(getFunctionLinkage(FD)); + } + /// getVTableLinkage - Return the appropriate linkage for the vtable, VTT, /// and type information of the given class. static llvm::GlobalVariable::LinkageTypes |