diff options
author | Daniel Dunbar <daniel@zuster.org> | 2009-04-14 06:19:49 +0000 |
---|---|---|
committer | Daniel Dunbar <daniel@zuster.org> | 2009-04-14 06:19:49 +0000 |
commit | b97b69244a4e7916c7b8fca28fa21b36ce5b30b2 (patch) | |
tree | 5cb64af38732fe4c01e24ca9977e76a918d0b1f4 /lib/CodeGen/CodeGenModule.cpp | |
parent | 44b0bc008ee11cdee69ad12210ca7550e4fa426a (diff) |
Add a comment on SetGlobalValueAttributes.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@69029 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CodeGenModule.cpp')
-rw-r--r-- | lib/CodeGen/CodeGenModule.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index be6ba2338a..1dafd39b2c 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -221,6 +221,11 @@ void CodeGenModule::EmitAnnotations() { gv->setSection("llvm.metadata"); } +/// SetGlobalValueAttributes - Set attributes for a global. +/// +/// FIXME: This is currently only done for aliases and functions, but +/// not for variables (these details are set in +/// EmitGlobalVarDefinition for variables). void CodeGenModule::SetGlobalValueAttributes(const Decl *D, GVALinkage Linkage, llvm::GlobalValue *GV, @@ -265,8 +270,8 @@ void CodeGenModule::SetGlobalValueAttributes(const Decl *D, setGlobalVisibility(GV, D); // Only add to llvm.used when we see a definition, otherwise we - // might add multiple times or risk the value being replaced by a - // subsequent RAUW. + // might add it multiple times or risk the value being replaced by + // a subsequent RAUW. if (D->hasAttr<UsedAttr>()) AddUsedGlobal(GV); } |