diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2008-05-29 15:09:15 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2008-05-29 15:09:15 +0000 |
| commit | ec2c12646aee07bf6bb1b4092d538d5860fd0661 (patch) | |
| tree | 8719a418f23b08d08f0e13ae2be86f7af3550143 /lib/CodeGen/CGExprScalar.cpp | |
| parent | 1e86b34f15f0502c13750ee1d6cf338def6e2242 (diff) | |
Fix an extremely subtle bug with pointer comparisons: they have to be
unsigned because it's possible (at least in theory) to have
have both positive and negative pointers pointing to the same object.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@51681 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CGExprScalar.cpp')
| -rw-r--r-- | lib/CodeGen/CGExprScalar.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/CodeGen/CGExprScalar.cpp b/lib/CodeGen/CGExprScalar.cpp index 9daa21eb34..fc8639dbf2 100644 --- a/lib/CodeGen/CGExprScalar.cpp +++ b/lib/CodeGen/CGExprScalar.cpp @@ -917,12 +917,12 @@ Value *ScalarExprEmitter::EmitCompare(const BinaryOperator *E,unsigned UICmpOpc, if (LHS->getType()->isFloatingPoint()) { Result = Builder.CreateFCmp((llvm::FCmpInst::Predicate)FCmpOpc, LHS, RHS, "cmp"); - } else if (LHSTy->isUnsignedIntegerType()) { - Result = Builder.CreateICmp((llvm::ICmpInst::Predicate)UICmpOpc, + } else if (LHSTy->isSignedIntegerType()) { + Result = Builder.CreateICmp((llvm::ICmpInst::Predicate)SICmpOpc, LHS, RHS, "cmp"); } else { - // Signed integers and pointers. - Result = Builder.CreateICmp((llvm::ICmpInst::Predicate)SICmpOpc, + // Unsigned integers and pointers. + Result = Builder.CreateICmp((llvm::ICmpInst::Predicate)UICmpOpc, LHS, RHS, "cmp"); } } else { |