diff options
| author | Chris Lattner <sabre@nondot.org> | 2010-06-26 20:27:24 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2010-06-26 20:27:24 +0000 |
| commit | e70ffd631179c15d358838464425e3464cf05a98 (patch) | |
| tree | 2900db0ba593f1df3795b11908b91de47d4a65ee /lib/CodeGen/CGExprScalar.cpp | |
| parent | abfe094ce71c42656dcb84a3bdc3e79cb3c16fc3 (diff) | |
implement rdar://7432000 - signed negate should codegen as NSW.
While I'm in there, adjust pointer to member adjustments as well.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@106955 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CGExprScalar.cpp')
| -rw-r--r-- | lib/CodeGen/CGExprScalar.cpp | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/lib/CodeGen/CGExprScalar.cpp b/lib/CodeGen/CGExprScalar.cpp index a46105e196..4372279175 100644 --- a/lib/CodeGen/CGExprScalar.cpp +++ b/lib/CodeGen/CGExprScalar.cpp @@ -997,13 +997,13 @@ Value *ScalarExprEmitter::EmitCastExpr(CastExpr *CE) { std::swap(DerivedDecl, BaseDecl); if (llvm::Constant *Adj = - CGF.CGM.GetNonVirtualBaseClassOffset(DerivedDecl, - CE->getBasePath())) { + CGF.CGM.GetNonVirtualBaseClassOffset(DerivedDecl, CE->getBasePath())){ if (CE->getCastKind() == CastExpr::CK_DerivedToBaseMemberPointer) - Src = Builder.CreateSub(Src, Adj, "adj"); + Src = Builder.CreateNSWSub(Src, Adj, "adj"); else - Src = Builder.CreateAdd(Src, Adj, "adj"); + Src = Builder.CreateNSWAdd(Src, Adj, "adj"); } + return Src; } @@ -1117,6 +1117,11 @@ Value *ScalarExprEmitter::VisitUnaryMinus(const UnaryOperator *E) { Value *Op = Visit(E->getSubExpr()); if (Op->getType()->isFPOrFPVectorTy()) return Builder.CreateFNeg(Op, "neg"); + + // Signed integer overflow is undefined behavior. + if (E->getType()->isSignedIntegerType()) + return Builder.CreateNSWNeg(Op, "neg"); + return Builder.CreateNeg(Op, "neg"); } |