diff options
| author | David Blaikie <dblaikie@gmail.com> | 2012-04-30 02:36:29 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2012-04-30 02:36:29 +0000 |
| commit | 262bc18e32500558af7cb0afa205b34bd37bafed (patch) | |
| tree | 6948b171ad9895169475e9f5808700781231a710 /lib/CodeGen/CGExprScalar.cpp | |
| parent | 298038352b34c5503db418201f3ddea6e56fd0e1 (diff) | |
Remove the ref/value inconsistency in filter_decl_iterator.
filter_decl_iterator had a weird mismatch where both op* and op-> returned T*
making it difficult to generalize this filtering behavior into a reusable
library of any kind.
This change errs on the side of value, making op-> return T* and op* return
T&.
(reviewed by Richard Smith)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155808 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CGExprScalar.cpp')
| -rw-r--r-- | lib/CodeGen/CGExprScalar.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/CodeGen/CGExprScalar.cpp b/lib/CodeGen/CGExprScalar.cpp index db4349b8e1..bce910ce18 100644 --- a/lib/CodeGen/CGExprScalar.cpp +++ b/lib/CodeGen/CGExprScalar.cpp @@ -1521,8 +1521,8 @@ Value *ScalarExprEmitter::VisitOffsetOfExpr(OffsetOfExpr *E) { // FIXME: It would be nice if we didn't have to loop here! for (RecordDecl::field_iterator Field = RD->field_begin(), FieldEnd = RD->field_end(); - Field != FieldEnd; (void)++Field, ++i) { - if (*Field == MemberDecl) + Field != FieldEnd; ++Field, ++i) { + if (&*Field == MemberDecl) break; } assert(i < RL.getFieldCount() && "offsetof field in wrong type"); |