aboutsummaryrefslogtreecommitdiff
path: root/lib/Checker/UnreachableCodeChecker.cpp
diff options
context:
space:
mode:
authorTom Care <tom.care@uqconnect.edu.au>2010-08-27 22:37:31 +0000
committerTom Care <tom.care@uqconnect.edu.au>2010-08-27 22:37:31 +0000
commitaaca011f78ce4d1ce08d4320da1326d4ae31609a (patch)
tree97f3334ecbc8d83065236604e4c9b199bb62ad77 /lib/Checker/UnreachableCodeChecker.cpp
parentd8421eddff2d63e8b1f317f8cd7b1aeee5fdfe8a (diff)
Remove an assertion in UnreachableCodeChecker that can be triggered by bugs in other checkers.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@112310 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Checker/UnreachableCodeChecker.cpp')
-rw-r--r--lib/Checker/UnreachableCodeChecker.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/lib/Checker/UnreachableCodeChecker.cpp b/lib/Checker/UnreachableCodeChecker.cpp
index fd98a7a75d..7a56c7f46b 100644
--- a/lib/Checker/UnreachableCodeChecker.cpp
+++ b/lib/Checker/UnreachableCodeChecker.cpp
@@ -188,8 +188,11 @@ const Stmt *UnreachableCodeChecker::getUnreachableStmt(const CFGBlock *CB) {
// There will never be more than one predecessor.
bool UnreachableCodeChecker::isInvalidPath(const CFGBlock *CB,
const ParentMap &PM) {
- // Assert this CFGBlock only has one or zero predecessors
- assert(CB->pred_size() == 0 || CB->pred_size() == 1);
+ // We only expect a predecessor size of 0 or 1. If it is >1, then an external
+ // condition has broken our assumption (for example, a sink being placed by
+ // another check). In these cases, we choose not to report.
+ if (CB->pred_size() > 1)
+ return true;
// If there are no predecessors, then this block is trivially unreachable
if (CB->pred_size() == 0)