diff options
author | Zhongxing Xu <xuzhongxing@gmail.com> | 2010-11-26 09:07:38 +0000 |
---|---|---|
committer | Zhongxing Xu <xuzhongxing@gmail.com> | 2010-11-26 09:07:38 +0000 |
commit | b1dbe0ee0d2e766067ab5a30daf89b2743ebbe43 (patch) | |
tree | 7b456dc2616cc3da12f32a53303042a5b58dc495 /lib/Checker/ReturnPointerRangeChecker.cpp | |
parent | 02fe28c8a6da29d4ad88d0900c133dcf22d24a75 (diff) |
Should not use StripCasts() in this context.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@120177 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Checker/ReturnPointerRangeChecker.cpp')
-rw-r--r-- | lib/Checker/ReturnPointerRangeChecker.cpp | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/lib/Checker/ReturnPointerRangeChecker.cpp b/lib/Checker/ReturnPointerRangeChecker.cpp index 0e7a5cf9d1..f743eeb6eb 100644 --- a/lib/Checker/ReturnPointerRangeChecker.cpp +++ b/lib/Checker/ReturnPointerRangeChecker.cpp @@ -48,19 +48,16 @@ void ReturnPointerRangeChecker::PreVisitReturnStmt(CheckerContext &C, SVal V = state->getSVal(RetE); const MemRegion *R = V.getAsRegion(); - if (!R) - return; - - R = R->StripCasts(); - if (!R) - return; const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(R); if (!ER) return; DefinedOrUnknownSVal Idx = cast<DefinedOrUnknownSVal>(ER->getIndex()); - + // Zero index is always in bound, this also passes ElementRegions created for + // pointer casts. + if (Idx.isZeroConstant()) + return; // FIXME: All of this out-of-bounds checking should eventually be refactored // into a common place. |