diff options
author | Jordan Rose <jordan_rose@apple.com> | 2013-03-01 19:45:10 +0000 |
---|---|---|
committer | Jordan Rose <jordan_rose@apple.com> | 2013-03-01 19:45:10 +0000 |
commit | 9abf1b4577b75ffcc46afbdfb55de334f68f05c0 (patch) | |
tree | 2bcdb024e90e00d4b58d95513abf14121c8afd2c /lib/Basic | |
parent | 516fb31d0536040334032e2af6b62cd6a5479d1c (diff) |
[analyzer] Suppress paths involving a reference whose rvalue is null.
Most map types have an operator[] that inserts a new element if the key
isn't found, then returns a reference to the value slot so that you can
assign into it. However, if the value type is a pointer, it will be
initialized to null. This is usually no problem.
However, if the user /knows/ the map contains a value for a particular key,
they may just use it immediately:
// From ClangSACheckersEmitter.cpp
recordGroupMap[group]->Checkers
In this case the analyzer reports a null dereference on the path where the
key is not in the map, even though the user knows that path is impossible
here. They could silence the warning by adding an assertion, but that means
splitting up the expression and introducing a local variable. (Note that
the analyzer has no way of knowing that recordGroupMap[group] will return
the same reference if called twice in a row!)
We already have logic that says a null dereference has a high chance of
being a false positive if the null came from an inlined function. This
patch simply extends that to references whose rvalues are null as well,
silencing several false positives in LLVM.
<rdar://problem/13239854>
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@176371 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Basic')
0 files changed, 0 insertions, 0 deletions