diff options
author | Richard Smith <richard-llvm@metafoo.co.uk> | 2012-07-17 01:27:33 +0000 |
---|---|---|
committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2012-07-17 01:27:33 +0000 |
commit | 6cfa78f6bd4e7d5e23366a0907f8f8792366bc4c (patch) | |
tree | 54020b0c5ce9d7ae14a94829dfeb54e435cb1bda /lib/Analysis/UninitializedValues.cpp | |
parent | 3df9a756d619dd6c560da97b514b3859c296b9a0 (diff) |
Uninitialized variables: two little changes:
* Treat compound assignment as a use, at Jordy's request.
* Always add compound assignments into the CFG, so we can correctly diagnose the use in 'return x += 1;'
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@160334 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/UninitializedValues.cpp')
-rw-r--r-- | lib/Analysis/UninitializedValues.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/Analysis/UninitializedValues.cpp b/lib/Analysis/UninitializedValues.cpp index 1b37c29990..acf695a1e9 100644 --- a/lib/Analysis/UninitializedValues.cpp +++ b/lib/Analysis/UninitializedValues.cpp @@ -447,7 +447,9 @@ void ClassifyRefs::VisitBinaryOperator(BinaryOperator *BO) { // when TransferFunctions visits it. A compound-assignment does not affect // whether a variable is uninitialized, and there's no point counting it as a // use. - if (BO->isAssignmentOp()) + if (BO->isCompoundAssignmentOp()) + classify(BO->getLHS(), Use); + else if (BO->getOpcode() == BO_Assign) classify(BO->getLHS(), Ignore); } |