diff options
| author | Ted Kremenek <kremenek@apple.com> | 2011-07-14 23:43:06 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2011-07-14 23:43:06 +0000 |
| commit | 05bcade0182524731cf4bc4984e08f63ddf62374 (patch) | |
| tree | 1bf764ac076951a8648a323455c0e21ced1dbd3c /lib/Analysis/UninitializedValues.cpp | |
| parent | 17031a25f777be12141360083c3b173a048371c8 (diff) | |
Fix false negative reported in PR 10358 by using 'Unknown' in -Wuninitialized to avoid cascading warnings. Patch by Kaelyn Uhrain.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@135217 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/UninitializedValues.cpp')
| -rw-r--r-- | lib/Analysis/UninitializedValues.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/lib/Analysis/UninitializedValues.cpp b/lib/Analysis/UninitializedValues.cpp index 1d6959d81b..5e00eebec8 100644 --- a/lib/Analysis/UninitializedValues.cpp +++ b/lib/Analysis/UninitializedValues.cpp @@ -495,9 +495,11 @@ void TransferFunctions::VisitBinaryOperator(clang::BinaryOperator *bo) { ValueVector::reference val = vals[vd]; if (isUninitialized(val)) { - if (bo->getOpcode() != BO_Assign) + if (bo->getOpcode() != BO_Assign) { reportUninit(res.getDeclRefExpr(), vd, isAlwaysUninit(val)); - val = Initialized; + val = Unknown; + } else + val = Initialized; } return; } @@ -526,7 +528,7 @@ void TransferFunctions::VisitUnaryOperator(clang::UnaryOperator *uo) { if (isUninitialized(val)) { reportUninit(res.getDeclRefExpr(), vd, isAlwaysUninit(val)); // Don't cascade warnings. - val = Initialized; + val = Unknown; } return; } @@ -558,7 +560,7 @@ void TransferFunctions::VisitCastExpr(clang::CastExpr *ce) { if (isUninitialized(val)) { reportUninit(res.getDeclRefExpr(), vd, isAlwaysUninit(val)); // Don't cascade warnings. - vals[vd] = Initialized; + vals[vd] = Unknown; } } return; |