diff options
author | Richard Trieu <rtrieu@google.com> | 2011-12-15 00:38:15 +0000 |
---|---|---|
committer | Richard Trieu <rtrieu@google.com> | 2011-12-15 00:38:15 +0000 |
commit | 2fe9b7fb07dff15dd15dd8755a9a9e6de0fe46fc (patch) | |
tree | 29e2aab8ed6d3dda663e31e3ed5434a0d3e26163 /lib/Analysis/FormatString.cpp | |
parent | 60ef308e51c71b760d7f598c1b763ceb7b768148 (diff) |
Modify how the -verify flag works. Currently, the verification string and
diagnostic message are compared. If either is a substring of the other, then
no error is given. This gives rise to an unexpected case:
// expect-error{{candidate function has different number of parameters}}
will match the following error messages from Clang:
candidate function has different number of parameters (expected 1 but has 2)
candidate function has different number of parameters
It will also match these other error messages:
candidate function
function has different number of parameters
number of parameters
This patch will change so that the verification string must be a substring of
the diagnostic message before accepting. Also, all the failing tests from this
change have been corrected. Some stats from this cleanup:
87 - removed extra spaces around verification strings
70 - wording updates to diagnostics
40 - extra leading or trailing characters (typos, unmatched parens or quotes)
35 - diagnostic level was included (error:, warning:, or note:)
18 - flag name put in the warning (-Wprotocol)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@146619 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/FormatString.cpp')
0 files changed, 0 insertions, 0 deletions