diff options
| author | Steve Naroff <snaroff@apple.com> | 2009-07-10 23:34:53 +0000 |
|---|---|---|
| committer | Steve Naroff <snaroff@apple.com> | 2009-07-10 23:34:53 +0000 |
| commit | 14108da7f7fc059772711e4ffee1322a27b152a7 (patch) | |
| tree | 5461a189505985c1c245c3f63a48030f0cd5e929 /lib/Analysis/CheckObjCInstMethSignature.cpp | |
| parent | 7ecbfbcddd278eede10bd38fa03a95a2110b191a (diff) | |
This patch includes a conceptually simple, but very intrusive/pervasive change.
The idea is to segregate Objective-C "object" pointers from general C pointers (utilizing the recently added ObjCObjectPointerType). The fun starts in Sema::GetTypeForDeclarator(), where "SomeInterface *" is now represented by a single AST node (rather than a PointerType whose Pointee is an ObjCInterfaceType). Since a significant amount of code assumed ObjC object pointers where based on C pointers/structs, this patch is very tedious. It should also explain why it is hard to accomplish this in smaller, self-contained patches.
This patch does most of the "heavy lifting" related to moving from PointerType->ObjCObjectPointerType. It doesn't include all potential "cleanups". The good news is additional cleanups can be done later (some are noted in the code). This patch is so large that I didn't want to include any changes that are purely aesthetic.
By making the ObjC types truly built-in, they are much easier to work with (and require fewer "hacks"). For example, there is no need for ASTContext::isObjCIdStructType() or ASTContext::isObjCClassStructType()! We believe this change (and the follow-up cleanups) will pay dividends over time.
Given the amount of code change, I do expect some fallout from this change (though it does pass all of the clang tests). If you notice any problems, please let us know asap! Thanks.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@75314 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/CheckObjCInstMethSignature.cpp')
| -rw-r--r-- | lib/Analysis/CheckObjCInstMethSignature.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/Analysis/CheckObjCInstMethSignature.cpp b/lib/Analysis/CheckObjCInstMethSignature.cpp index 28814867bd..c4e586d2e4 100644 --- a/lib/Analysis/CheckObjCInstMethSignature.cpp +++ b/lib/Analysis/CheckObjCInstMethSignature.cpp @@ -30,8 +30,8 @@ static bool AreTypesCompatible(QualType Derived, QualType Ancestor, // Right now don't compare the compatibility of pointers. That involves // looking at subtyping relationships. FIXME: Future patch. - if ((Derived->isPointerType() || Derived->isObjCQualifiedIdType()) && - (Ancestor->isPointerType() || Ancestor->isObjCQualifiedIdType())) + if ((Derived->isPointerType() || Derived->isObjCObjectPointerType()) && + (Ancestor->isPointerType() || Ancestor->isObjCObjectPointerType())) return true; return C.typesAreCompatible(Derived, Ancestor); |