diff options
author | Richard Smith <richard-llvm@metafoo.co.uk> | 2011-12-12 19:10:03 +0000 |
---|---|---|
committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2011-12-12 19:10:03 +0000 |
commit | 4cd9b8f7fb2cebf614e6e2bc766fad27ffd2e9de (patch) | |
tree | a7a36ba370ecade52568456e684b0d98067bc928 /lib/AST/ExprConstant.cpp | |
parent | d83d2e73fdbe425acc4cac7b8130c464cb98333d (diff) |
Clean up diagnostic wording for disallowed casts in C++11 constant expressions.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@146395 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/AST/ExprConstant.cpp')
-rw-r--r-- | lib/AST/ExprConstant.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/lib/AST/ExprConstant.cpp b/lib/AST/ExprConstant.cpp index 62d70dd978..3a897ab348 100644 --- a/lib/AST/ExprConstant.cpp +++ b/lib/AST/ExprConstant.cpp @@ -2226,8 +2226,13 @@ bool PointerExprEvaluator::VisitCastExpr(const CastExpr* E) { // Bitcasts to cv void* are static_casts, not reinterpret_casts, so are // permitted in constant expressions in C++11. Bitcasts from cv void* are // also static_casts, but we disallow them as a resolution to DR1312. - if (!E->getType()->isVoidPointerType()) - CCEDiag(E, diag::note_constexpr_invalid_cast) << 2; + if (!E->getType()->isVoidPointerType()) { + if (SubExpr->getType()->isVoidPointerType()) + CCEDiag(E, diag::note_constexpr_invalid_cast) + << 3 << SubExpr->getType(); + else + CCEDiag(E, diag::note_constexpr_invalid_cast) << 2; + } if (!Visit(SubExpr)) return false; Result.Designator.setInvalid(); |