diff options
author | Ted Kremenek <kremenek@apple.com> | 2009-01-12 22:49:54 +0000 |
---|---|---|
committer | Ted Kremenek <kremenek@apple.com> | 2009-01-12 22:49:54 +0000 |
commit | ee49d0496bb8ff2bbf479bb7fbcfbdc71eed7461 (patch) | |
tree | 4bc8901a7a2fa97a40b24f640dff908099ec3b19 /lib/AST/DeclObjC.cpp | |
parent | 4920f1ffb62b13b88e579476803c093f97f3e17f (diff) |
Fix crasher due to use-after-release: DeclContext now owns all ObjCMethodDecls, and shouldn't be released elsewhere.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@62113 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/AST/DeclObjC.cpp')
-rw-r--r-- | lib/AST/DeclObjC.cpp | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/lib/AST/DeclObjC.cpp b/lib/AST/DeclObjC.cpp index 9fc0f763bb..ea7a047780 100644 --- a/lib/AST/DeclObjC.cpp +++ b/lib/AST/DeclObjC.cpp @@ -73,13 +73,9 @@ void ObjCInterfaceDecl::Destroy(ASTContext& C) { for (ivar_iterator I=ivar_begin(), E=ivar_end(); I!=E; ++I) if (*I) (*I)->Destroy(C); - for (method_iterator I=meth_begin(), E=meth_end(); I!=E; ++I) - if (*I) const_cast<ObjCMethodDecl*>((*I))->Destroy(C); - // FIXME: Because there is no clear ownership // role between ObjCInterfaceDecls and the ObjCPropertyDecls that they // reference, we destroy ObjCPropertyDecls in ~TranslationUnit. - Decl::Destroy(C); } @@ -115,20 +111,6 @@ ObjCProtocolDecl::~ObjCProtocolDecl() { delete [] PropertyDecl; } -void ObjCProtocolDecl::Destroy(ASTContext& C) { - - // Referenced Protocols are not owned, so don't Destroy them. - - for (method_iterator I=meth_begin(), E=meth_end(); I!=E; ++I) - if (*I) const_cast<ObjCMethodDecl*>((*I))->Destroy(C); - - // FIXME: Because there is no clear ownership - // role between ObjCProtocolDecls and the ObjCPropertyDecls that they - // reference, we destroy ObjCPropertyDecls in ~TranslationUnit. - - Decl::Destroy(C); -} - ObjCClassDecl *ObjCClassDecl::Create(ASTContext &C, DeclContext *DC, SourceLocation L, |