diff options
author | Anna Zaks <ganna@apple.com> | 2013-01-19 02:18:15 +0000 |
---|---|---|
committer | Anna Zaks <ganna@apple.com> | 2013-01-19 02:18:15 +0000 |
commit | 1dfebd9f995066a229c34516eb14bc69c6bcde2c (patch) | |
tree | 8440cd3c2a633129cce870843c4b9a63baa5b314 /include/clang/StaticAnalyzer/Core/BugReporter | |
parent | f30527901f84c9bf223db143b216a9061ee9e342 (diff) |
[analyzer] Suppress warnings coming out of macros defined in sys/queue.h
Suppress the warning by just not emitting the report. The sink node
would get generated, which is fine since we did reach a bad state.
Motivation
Due to the way code is structured in some of these macros, we do not
reason correctly about it and report false positives. Specifically, the
following loop reports a use-after-free. Because of the way the code is
structured inside of the macro, the analyzer assumes that the list can
have cycles, so you end up with use-after-free in the loop, that is
safely deleting elements of the list. (The user does not have a way to
teach the analyzer about shape of data structures.)
SLIST_FOREACH_SAFE(item, &ctx->example_list, example_le, tmpitem) {
if (item->index == 3) { // if you remove each time, no complaints
assert((&ctx->example_list)->slh_first == item);
SLIST_REMOVE(&ctx->example_list, item, example_s, example_le);
free(item);
}
}
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@172883 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include/clang/StaticAnalyzer/Core/BugReporter')
-rw-r--r-- | include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h b/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h index 7a87e47f74..74579b7b4c 100644 --- a/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h +++ b/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h @@ -457,6 +457,11 @@ public: void Register(BugType *BT); + /// \brief Suppress reports that might lead to known false positives. + /// + /// Currently this suppresses reports based on locations of bugs. + bool suppressReport(BugReport *R); + /// \brief Add the given report to the set of reports tracked by BugReporter. /// /// The reports are usually generated by the checkers. Further, they are |