diff options
author | David Blaikie <dblaikie@gmail.com> | 2012-04-09 16:37:11 +0000 |
---|---|---|
committer | David Blaikie <dblaikie@gmail.com> | 2012-04-09 16:37:11 +0000 |
commit | eb52f86a62db523e3c993686b3ed92c55d59d53c (patch) | |
tree | 5134ec06185e7f16efc2e2cac6543cd84f0a45a5 /include/clang/Frontend/CodeGenOptions.h | |
parent | 649ee3fec12dcf7167630ff88087ad116e9eefa6 (diff) |
Fix bugs found by -Wconstant-conversion improvements currently under review.
Specifically, using a an integer outside [0, 1] as a boolean constant seems to
be an easy mistake to make with things like "x == a || b" where the author
intended "x == a || x == b".
The bug caused by calling SkipUntil with three token kinds was also identified
by a VC diagnostic & reported by Francois Pichet as review feedback for my
commit r154163. I've included test cases to verify the error recovery that was
broken/poorly implemented due to this bug.
The other fix (lib/Sema/SemaExpr.cpp) seems like that code was never actually
reached in any of Clang's tests & is related to Objective C features I'm not
familiar with, so I've not been able to construct a test case for it. Perhaps
someone else can.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@154325 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include/clang/Frontend/CodeGenOptions.h')
0 files changed, 0 insertions, 0 deletions