diff options
author | Steve Naroff <snaroff@apple.com> | 2007-09-12 14:07:44 +0000 |
---|---|---|
committer | Steve Naroff <snaroff@apple.com> | 2007-09-12 14:07:44 +0000 |
commit | bb204693855fe87a6e4b23dfd053722026dbe87c (patch) | |
tree | df19766a862976819cb17a5cdcb6ec24b7d482a1 /Driver/PrintParserCallbacks.cpp | |
parent | 155383b0fcd0a12a103310010f8c0d084b90b090 (diff) |
Fix the following bug submitted by Ted Kremenek:
void func() {
int xx = xx; // incorrectly diagnosed 'xx' as an undeclared identifier.
}
This smallish bug resulted in a largish fix. Here are some highlights:
- Needed to make sure ParseDeclarator is called *before* parsing any
initializer. Removed the "Init" argument to ParseDeclarator.
- Added AddInitializerToDecl() to the Action & Sema classes.
In Sema, this hook is responsible for validating the initializer and
installing it into the respective decl.
- Moved several semantic checks from ParseDeclarator() to
FinalizeDeclaratorGroup(). Previously, this hook was only responsible for
reversing a list. Now it plays a much larger semantic role.
All of the above changes ended up simplifying ParseDeclarator(), which
is goodness...
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@41877 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'Driver/PrintParserCallbacks.cpp')
-rw-r--r-- | Driver/PrintParserCallbacks.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Driver/PrintParserCallbacks.cpp b/Driver/PrintParserCallbacks.cpp index 3730d19a7d..3e37514bb2 100644 --- a/Driver/PrintParserCallbacks.cpp +++ b/Driver/PrintParserCallbacks.cpp @@ -25,7 +25,7 @@ namespace { /// ParseDeclarator - This callback is invoked when a declarator is parsed /// and 'Init' specifies the initializer if any. This is for things like: /// "int X = 4" or "typedef int foo". - virtual DeclTy *ParseDeclarator(Scope *S, Declarator &D, ExprTy *Init, + virtual DeclTy *ParseDeclarator(Scope *S, Declarator &D, DeclTy *LastInGroup) { std::cout << "ParseDeclarator "; if (IdentifierInfo *II = D.getIdentifier()) { @@ -36,7 +36,7 @@ namespace { std::cout << "\n"; // Pass up to EmptyActions so that the symbol table is maintained right. - return MinimalAction::ParseDeclarator(S, D, Init, LastInGroup); + return MinimalAction::ParseDeclarator(S, D, LastInGroup); } /// PopScope - This callback is called immediately before the specified scope |