aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnders Carlsson <andersca@mac.com>2009-07-23 21:16:33 +0000
committerAnders Carlsson <andersca@mac.com>2009-07-23 21:16:33 +0000
commitfaaec2234f21bf175dd05c723072202cdf39cb2f (patch)
tree6786920699ff1b37825f2e6cfbbfdc0e583f4c38
parentec586e7b10394aeed25c8e5ee02d230951826136 (diff)
Correct a thinko in bitfield layout code. Fixes PR4611.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@76898 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/CodeGen/CGRecordLayoutBuilder.cpp6
-rw-r--r--test/CodeGen/PR4611-bitfield-layout.c6
2 files changed, 8 insertions, 4 deletions
diff --git a/lib/CodeGen/CGRecordLayoutBuilder.cpp b/lib/CodeGen/CGRecordLayoutBuilder.cpp
index 2d10b1f030..455b92996a 100644
--- a/lib/CodeGen/CGRecordLayoutBuilder.cpp
+++ b/lib/CodeGen/CGRecordLayoutBuilder.cpp
@@ -88,10 +88,8 @@ void CGRecordLayoutBuilder::LayoutBitField(const FieldDecl *D,
AppendBytes(NumBytesToAppend);
- if (!NumBytesToAppend)
- BitsAvailableInLastField -= FieldSize;
- else
- BitsAvailableInLastField = NumBytesToAppend * 8 - FieldSize;
+ BitsAvailableInLastField =
+ getNextFieldOffsetInBytes() * 8 - (FieldOffset + FieldSize);
}
bool CGRecordLayoutBuilder::LayoutField(const FieldDecl *D,
diff --git a/test/CodeGen/PR4611-bitfield-layout.c b/test/CodeGen/PR4611-bitfield-layout.c
new file mode 100644
index 0000000000..ef698d5ab3
--- /dev/null
+++ b/test/CodeGen/PR4611-bitfield-layout.c
@@ -0,0 +1,6 @@
+// RUN: clang-cc -triple i386-unknown-unknown %s -emit-llvm -o %t &&
+// RUN: grep "struct.object_entry = type <{ i8, i8, i8, i8 }>" %t
+
+struct object_entry {
+ unsigned int type:3, pack_id:16, depth:13;
+} entries;