diff options
| author | Dan Gohman <sunfish@mozilla.com> | 2014-02-28 13:07:59 -0800 |
|---|---|---|
| committer | Dan Gohman <sunfish@mozilla.com> | 2014-02-28 13:30:42 -0800 |
| commit | f59469c5a434866f9a69439555a3684faa16e7fc (patch) | |
| tree | a79b7801343e6565103ccfa32fb8d79f122089b0 | |
| parent | a5bbe64d08bc217af5daa43761b587a0c9cc88fa (diff) | |
Drop addAsmMemoryAroundSyncSynchronize() and asmMemoryIsFence().
For us, staying in sync with upstream on issues related to the memory model
is more important. None of clang, gcc, nor icc appear to offer these features.
If such features are desirable, they should ideally be implemented in upstream
clang, in a target-independent way, since this issue would affect users of all
platforms which support threads, not just PNaCl or Emscripten.
| -rw-r--r-- | lib/CodeGen/TargetInfo.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/lib/CodeGen/TargetInfo.cpp b/lib/CodeGen/TargetInfo.cpp index 5aa982e255..7d0d1768ed 100644 --- a/lib/CodeGen/TargetInfo.cpp +++ b/lib/CodeGen/TargetInfo.cpp @@ -428,10 +428,6 @@ class EmscriptenTargetCodeGenInfo : public TargetCodeGenInfo { public: explicit EmscriptenTargetCodeGenInfo(CodeGen::CodeGenTypes &CGT) : TargetCodeGenInfo(new EmscriptenABIInfo(CGT)) {} - - // TODO: Re-evaluate whether these hacks, borrowed from PNaCl, are necessary. - bool addAsmMemoryAroundSyncSynchronize() const { return true; } - bool asmMemoryIsFence() const { return true; } }; /// \brief Classify argument of given type \p Ty. |