diff options
| author | Chris Lattner <sabre@nondot.org> | 2009-04-05 00:52:59 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2009-04-05 00:52:59 +0000 |
| commit | f502691c86299ed23b7e121e27610ba5bb44a1ee (patch) | |
| tree | cf8c5c53f4a60aad65270006ca4fd22d17d503b6 | |
| parent | ead616c5d8681a41b11273327813e61bda01907a (diff) | |
GCC compatibility: gcc allows applying va_args to const
va_lists for some reason. This fixes rdar://6726818
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68434 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Sema/SemaExpr.cpp | 5 | ||||
| -rw-r--r-- | test/Sema/varargs.c | 7 |
2 files changed, 11 insertions, 1 deletions
diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index 55eaaa4bc8..a43c2c370e 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -4724,7 +4724,10 @@ Sema::OwningExprResult Sema::ActOnVAArg(SourceLocation BuiltinLoc, Expr *E = static_cast<Expr*>(expr.get()); UsualUnaryConversions(E); - if (CheckAssignmentConstraints(VaListType, E->getType()) != Compatible) + AssignConvertType ConvResult = + CheckAssignmentConstraints(VaListType, E->getType()); + if (ConvResult != Compatible && + ConvResult != CompatiblePointerDiscardsQualifiers) return ExprError(Diag(E->getLocStart(), diag::err_first_argument_to_va_arg_not_of_type_va_list) << E->getType() << E->getSourceRange()); diff --git a/test/Sema/varargs.c b/test/Sema/varargs.c index 434e4ce291..7255f9fc06 100644 --- a/test/Sema/varargs.c +++ b/test/Sema/varargs.c @@ -60,3 +60,10 @@ void f7(int a, ...) { int *x = &__builtin_va_arg(ap, int); // expected-error {{address expression must be an lvalue or a function designator}} __builtin_va_end(ap); } + +// rdar://6726818 +void f8() { + const __builtin_va_list args2; + (void)__builtin_va_arg(args2, int); +} + |