aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnna Zaks <ganna@apple.com>2011-08-22 18:54:07 +0000
committerAnna Zaks <ganna@apple.com>2011-08-22 18:54:07 +0000
commitedf4daead543ab594012ef1704c7c5dd0a93f45f (patch)
tree46bc6bedc8cd3c256014629814f5a382aa51ce99
parent70c7b10c64beed3e08da004c10ed5170c00df8f9 (diff)
Clean up the CFRefBugReport - remove the members, which got moved to the CFRefReportVisitors.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@138259 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/StaticAnalyzer/Core/CFRefCount.cpp18
1 files changed, 5 insertions, 13 deletions
diff --git a/lib/StaticAnalyzer/Core/CFRefCount.cpp b/lib/StaticAnalyzer/Core/CFRefCount.cpp
index 6c35d1ae9c..4ade451ba5 100644
--- a/lib/StaticAnalyzer/Core/CFRefCount.cpp
+++ b/lib/StaticAnalyzer/Core/CFRefCount.cpp
@@ -1945,38 +1945,30 @@ namespace {
};
class CFRefReport : public BugReport {
- protected:
- SymbolRef Sym;
- const CFRefCount &TF;
public:
CFRefReport(CFRefBug& D, const CFRefCount &tf,
ExplodedNode *n, SymbolRef sym, bool registerVisitor = true)
- : BugReport(D, D.getDescription(), n), Sym(sym), TF(tf) {
+ : BugReport(D, D.getDescription(), n) {
if (registerVisitor)
addVisitor(new CFRefReportVisitor(sym, tf));
}
CFRefReport(CFRefBug& D, const CFRefCount &tf,
ExplodedNode *n, SymbolRef sym, StringRef endText)
- : BugReport(D, D.getDescription(), endText, n), Sym(sym), TF(tf) {
+ : BugReport(D, D.getDescription(), endText, n) {
addVisitor(new CFRefReportVisitor(sym, tf));
}
virtual ~CFRefReport() {}
- CFRefBug& getBugType() const {
- return (CFRefBug&) BugReport::getBugType();
- }
-
virtual std::pair<ranges_iterator, ranges_iterator> getRanges() {
- if (!getBugType().isLeak())
+ const CFRefBug& BugTy = static_cast<CFRefBug&>(getBugType());
+ if (!BugTy.isLeak())
return BugReport::getRanges();
else
return std::make_pair(ranges_iterator(), ranges_iterator());
}
- SymbolRef getSymbol() const { return Sym; }
-
std::pair<const char**,const char**> getExtraDescriptiveText();
};
@@ -2468,7 +2460,7 @@ CFRefLeakReport::CFRefLeakReport(CFRefBug& D, const CFRefCount &tf,
const ExplodedNode *AllocNode = 0;
llvm::tie(AllocNode, AllocBinding) = // Set AllocBinding.
- GetAllocationSite(Eng.getStateManager(), getErrorNode(), getSymbol());
+ GetAllocationSite(Eng.getStateManager(), getErrorNode(), sym);
// Get the SourceLocation for the allocation site.
ProgramPoint P = AllocNode->getLocation();