diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2010-11-08 22:53:18 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2010-11-08 22:53:18 +0000 |
| commit | ed171b80e49c1ef3dcb9c2aa238cc50340ac6e90 (patch) | |
| tree | 124adef35d78c1c6002488209e418b660a1d9f9b | |
| parent | b5b38adbe29cd82711595bd184d6123125bd9a9b (diff) | |
Provide a precise builtin declaration for objc_msgSend
to avoid a bogus warning. Fixes //rdar: //8632525
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@118451 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/clang/Basic/Builtins.def | 7 | ||||
| -rw-r--r-- | lib/AST/ASTContext.cpp | 6 | ||||
| -rw-r--r-- | test/CodeGenObjC/implicit-objc_msgSend.m | 2 | ||||
| -rw-r--r-- | test/SemaObjC/builtin_objc_msgSend.m | 3 |
4 files changed, 13 insertions, 5 deletions
diff --git a/include/clang/Basic/Builtins.def b/include/clang/Basic/Builtins.def index eca73774f0..28a5078409 100644 --- a/include/clang/Basic/Builtins.def +++ b/include/clang/Basic/Builtins.def @@ -29,6 +29,8 @@ // d -> double // z -> size_t // F -> constant CFString +// G -> id +// H -> SEL // a -> __builtin_va_list // A -> "reference" to __builtin_va_list // V -> Vector, following num elements and a base type. @@ -559,11 +561,8 @@ LIBBUILTIN(_exit, "vi", "fr", "unistd.h") // POSIX setjmp.h LIBBUILTIN(_longjmp, "vJi", "fr", "setjmp.h") LIBBUILTIN(siglongjmp, "vSJi", "fr", "setjmp.h") - -// FIXME: This type isn't very correct, it should be // id objc_msgSend(id, SEL) -// but we need new type letters for that. -LIBBUILTIN(objc_msgSend, "v*.", "f", "objc/message.h") +LIBBUILTIN(objc_msgSend, "GGH.", "f", "objc/message.h") BUILTIN(__builtin_objc_memmove_collectable, "v*v*vC*z", "nF") // Builtin math library functions diff --git a/lib/AST/ASTContext.cpp b/lib/AST/ASTContext.cpp index b2451a2d86..26e53ca57a 100644 --- a/lib/AST/ASTContext.cpp +++ b/lib/AST/ASTContext.cpp @@ -5384,6 +5384,12 @@ static QualType DecodeTypeFromStr(const char *&Str, ASTContext &Context, case 'F': Type = Context.getCFConstantStringType(); break; + case 'G': + Type = Context.getObjCIdType(); + break; + case 'H': + Type = Context.getObjCSelType(); + break; case 'a': Type = Context.getBuiltinVaListType(); assert(!Type.isNull() && "builtin va list type not initialized!"); diff --git a/test/CodeGenObjC/implicit-objc_msgSend.m b/test/CodeGenObjC/implicit-objc_msgSend.m index a21e869229..322f82e920 100644 --- a/test/CodeGenObjC/implicit-objc_msgSend.m +++ b/test/CodeGenObjC/implicit-objc_msgSend.m @@ -1,5 +1,5 @@ // RUN: %clang_cc1 -triple x86_64-apple-darwin9 -emit-llvm -o %t %s -// RUN: grep -F 'declare i8* @objc_msgSend(...)' %t +// RUN: grep -F 'declare i8* @objc_msgSend(i8*, i8*, ...)' %t typedef struct objc_selector *SEL; id f0(id x, SEL s) { diff --git a/test/SemaObjC/builtin_objc_msgSend.m b/test/SemaObjC/builtin_objc_msgSend.m new file mode 100644 index 0000000000..7530d904f4 --- /dev/null +++ b/test/SemaObjC/builtin_objc_msgSend.m @@ -0,0 +1,3 @@ +// RUN: %clang_cc1 %s -fsyntax-only -verify +// rdar: // 8632525 +extern id objc_msgSend(id self, SEL op, ...); |