aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouglas Gregor <dgregor@apple.com>2009-02-03 19:26:08 +0000
committerDouglas Gregor <dgregor@apple.com>2009-02-03 19:26:08 +0000
commite2c565d488bc74a506d49fe37df4268fa35637b3 (patch)
treeed147ad41097548ff9d09f75a2f835d45acc2e47
parent2a3009a432bdcec59e6383d7b2b17494d6f91649 (diff)
When looking for a tag name via unqualified name lookup, only look in
scopes where the name would be considered a redeclaration if we know that we're declaring or defining that tag. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@63647 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Sema/SemaDecl.cpp3
-rw-r--r--test/SemaCXX/member-name-lookup.cpp3
-rw-r--r--test/SemaCXX/using-directive.cpp4
3 files changed, 5 insertions, 5 deletions
diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 39747b63ee..66b72ecad4 100644
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -2829,7 +2829,8 @@ Sema::DeclTy *Sema::ActOnTag(Scope *S, unsigned TagSpec, TagKind TK,
// FIXME: We're looking into outer scopes here, even when we
// shouldn't be. Doing so can result in ambiguities that we
// shouldn't be diagnosing.
- LookupResult R = LookupName(S, Name, LookupTagName);
+ LookupResult R = LookupName(S, Name, LookupTagName,
+ /*RedeclarationOnly=*/(TK != TK_Reference));
if (R.isAmbiguous()) {
DiagnoseAmbiguousLookup(R, Name, NameLoc);
// FIXME: This is not best way to recover from case like:
diff --git a/test/SemaCXX/member-name-lookup.cpp b/test/SemaCXX/member-name-lookup.cpp
index a19161203e..f48a99add4 100644
--- a/test/SemaCXX/member-name-lookup.cpp
+++ b/test/SemaCXX/member-name-lookup.cpp
@@ -141,6 +141,5 @@ struct HasMemberType2 {
};
struct HasAnotherMemberType : HasMemberType1, HasMemberType2 {
- // FIXME: this is well-formed, but we diagnose an ambiguity here
- // struct type { };
+ struct type { };
};
diff --git a/test/SemaCXX/using-directive.cpp b/test/SemaCXX/using-directive.cpp
index f00209863d..baf5d58126 100644
--- a/test/SemaCXX/using-directive.cpp
+++ b/test/SemaCXX/using-directive.cpp
@@ -69,6 +69,6 @@ class X {
namespace N {
// FIXME: both of these should work, but they currently cause an ambiguity.
- // struct K2;
- // struct K2 { };
+ struct K2;
+ struct K2 { };
}