Address review comments for #pragma weak.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@72926 91177308-0d34-0410-b5e6-96231b3b80d8

3 files changed, 6 insertions, 5 deletions

diff --git a/include/clang/Parse/Action.h b/include/clang/Parse/Action.h
index eadff639a2..588e659176 100644
--- a/include/clang/Parse/Action.h
+++ b/include/clang/Parse/Action.h
@@ -1750,7 +1750,7 @@ public:
     return;
   }
   
-  /// ActOnPragmaPack - Called on well formed #pragma pack(...).
+  /// ActOnPragmaUnused - Called on well formed #pragma unused(...).
   virtual void ActOnPragmaUnused(ExprTy **Exprs, unsigned NumExprs,
                                  SourceLocation PragmaLoc, 
                                  SourceLocation LParenLoc,
@@ -1758,14 +1758,14 @@ public:
     return;
   }
 
-  /// ActOnPragmaPack - Called on well formed #pragma weak ident.
+  /// ActOnPragmaWeakID - Called on well formed #pragma weak ident.
   virtual void ActOnPragmaWeakID(IdentifierInfo* WeakName,
                                  SourceLocation PragmaLoc,
                                  SourceLocation WeakNameLoc) {
     return;
   }
 
-  /// ActOnPragmaPack - Called on well formed #pragma weak ident = ident.
+  /// ActOnPragmaWeakAlias - Called on well formed #pragma weak ident = ident.
   virtual void ActOnPragmaWeakAlias(IdentifierInfo* WeakName,
                                     IdentifierInfo* AliasName,
                                     SourceLocation PragmaLoc,
diff --git a/lib/Sema/Sema.h b/lib/Sema/Sema.h
index 743c46b71b..736a496cff 100644
--- a/lib/Sema/Sema.h
+++ b/lib/Sema/Sema.h
@@ -2451,12 +2451,12 @@ public:
                                  SourceLocation LParenLoc,
                                  SourceLocation RParenLoc);
 
-  /// ActOnPragmaPack - Called on well formed #pragma weak ident.
+  /// ActOnPragmaWeakID - Called on well formed #pragma weak ident.
   virtual void ActOnPragmaWeakID(IdentifierInfo* WeakName,
                                  SourceLocation PragmaLoc,
                                  SourceLocation WeakNameLoc);
 
-  /// ActOnPragmaPack - Called on well formed #pragma weak ident = ident.
+  /// ActOnPragmaWeakAlias - Called on well formed #pragma weak ident = ident.
   virtual void ActOnPragmaWeakAlias(IdentifierInfo* WeakName,
                                     IdentifierInfo* AliasName,
                                     SourceLocation PragmaLoc,
diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 18636a4ab1..51b5449d9f 100644
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -4439,6 +4439,7 @@ void Sema::ActOnPragmaWeakAlias(IdentifierInfo* Name,
   // FIXME: This implementation is an ugly hack!
   if (PrevDecl) {
     PrevDecl->addAttr(::new (Context) AliasAttr(AliasName->getName()));
+    PrevDecl->addAttr(::new (Context) WeakAttr());
     return;
   }
   Diag(PragmaLoc, diag::err_unsupported_pragma_weak);