aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2010-03-05 01:21:10 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2010-03-05 01:21:10 +0000
commitbc6afd158cc67b5f87dcc2d8efe2a2254af8debe (patch)
tree2329d6ce1c741d72420e8149ea95f569379a9ede
parent42738573253da1bd61f9c44f8d77f600d3b0cd1c (diff)
Don't produce an alias for a destructor if the target is weak.
This fixes bootstrap on ELF systems :-) git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@97773 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/CodeGen/CGCXX.cpp16
1 files changed, 16 insertions, 0 deletions
diff --git a/lib/CodeGen/CGCXX.cpp b/lib/CodeGen/CGCXX.cpp
index 4889fc08f4..cd5d64697d 100644
--- a/lib/CodeGen/CGCXX.cpp
+++ b/lib/CodeGen/CGCXX.cpp
@@ -109,6 +109,16 @@ bool CodeGenModule::TryEmitBaseDestructorAsAlias(const CXXDestructorDecl *D) {
GlobalDecl(BaseD, Dtor_Base));
}
+static bool isWeakForLinker(llvm::GlobalValue::LinkageTypes Linkage) {
+ return (Linkage == llvm::GlobalValue::AvailableExternallyLinkage ||
+ Linkage == llvm::GlobalValue::WeakAnyLinkage ||
+ Linkage == llvm::GlobalValue::WeakODRLinkage ||
+ Linkage == llvm::GlobalValue::LinkOnceAnyLinkage ||
+ Linkage == llvm::GlobalValue::LinkOnceODRLinkage ||
+ Linkage == llvm::GlobalValue::CommonLinkage ||
+ Linkage == llvm::GlobalValue::ExternalWeakLinkage);
+}
+
/// Try to emit a definition as a global alias for another definition.
bool CodeGenModule::TryEmitDefinitionAsAlias(GlobalDecl AliasDecl,
GlobalDecl TargetDecl) {
@@ -142,6 +152,12 @@ bool CodeGenModule::TryEmitDefinitionAsAlias(GlobalDecl AliasDecl,
return true;
}
+ llvm::GlobalValue::LinkageTypes TargetLinkage
+ = getFunctionLinkage(cast<FunctionDecl>(TargetDecl.getDecl()));
+
+ if (isWeakForLinker(TargetLinkage))
+ return true;
+
// Derive the type for the alias.
const llvm::PointerType *AliasType
= getTypes().GetFunctionType(AliasDecl)->getPointerTo();