aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnders Carlsson <andersca@mac.com>2010-04-21 20:28:29 +0000
committerAnders Carlsson <andersca@mac.com>2010-04-21 20:28:29 +0000
commitb99c666a940e93bcfcaeddc01515c94472e28a20 (patch)
treed4d178f0b8696a8d18ea83acbd1b225b6b3ea0ed
parentf95861a4ab6bbd6a975ed079dd70eb1cc22f4467 (diff)
Diagnose access to fields with private constructors.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@102025 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/clang/Basic/DiagnosticSemaKinds.td3
-rw-r--r--lib/Sema/SemaAccess.cpp7
2 files changed, 10 insertions, 0 deletions
diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td
index a5be82df86..eb53d6ca38 100644
--- a/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/include/clang/Basic/DiagnosticSemaKinds.td
@@ -462,6 +462,9 @@ def err_access_ctor :
def err_access_ctor_base :
Error<"base class %0 has %select{private|protected}1 constructor">,
NoSFINAE;
+def err_access_ctor_field :
+ Error<"field of type %1 has %select{private|protected}2 constructor">,
+ NoSFINAE;
def err_access_ctor_vbase :
Error<"inherited virtual base class %0 has "
"%select{private|protected}1 constructor">,
diff --git a/lib/Sema/SemaAccess.cpp b/lib/Sema/SemaAccess.cpp
index 1a96c26be1..f71d36ad7f 100644
--- a/lib/Sema/SemaAccess.cpp
+++ b/lib/Sema/SemaAccess.cpp
@@ -1150,6 +1150,13 @@ Sema::AccessResult Sema::CheckConstructorAccess(SourceLocation UseLoc,
<< Entity.getBaseSpecifier()->getType());
break;
}
+
+ case InitializedEntity::EK_Member: {
+ const FieldDecl *Field = cast<FieldDecl>(Entity.getDecl());
+ AccessEntity.setDiag(PDiag(diag::err_access_ctor_field)
+ << Field->getDeclName() << Field->getType());
+ break;
+ }
}