diff options
| author | Steve Naroff <snaroff@apple.com> | 2007-12-18 03:41:15 +0000 |
|---|---|---|
| committer | Steve Naroff <snaroff@apple.com> | 2007-12-18 03:41:15 +0000 |
| commit | b99a4a3630478946ca963d654e40a8d100890d64 (patch) | |
| tree | dce9bf70a14783b349d6c4a1a42be73cf117f6c9 | |
| parent | 222d2c8b7886e37ba22f0b25ac7a6552f7cc8492 (diff) | |
Fixe bogus error for variable argument methods. Sema::ObjcGetTypeForMethodDefinition() wasn't preserving the isVariadic boolean. Another fix is to avoid synthsizing the function decl entirely, however this is a separate issue that I don't want to deal with now. Also added a FIXME to Sema::CheckFunctionCall(), which is currently emitting a bogus warning.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@45146 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | Sema/SemaChecking.cpp | 2 | ||||
| -rw-r--r-- | Sema/SemaType.cpp | 2 | ||||
| -rw-r--r-- | test/Sema/va-method.m | 17 |
3 files changed, 19 insertions, 2 deletions
diff --git a/Sema/SemaChecking.cpp b/Sema/SemaChecking.cpp index b366a2b70f..4d2e362038 100644 --- a/Sema/SemaChecking.cpp +++ b/Sema/SemaChecking.cpp @@ -62,7 +62,7 @@ Sema::CheckFunctionCall(Expr *Fn, diag::err_va_start_used_in_non_variadic_function); return true; } - + // FIXME: This isn't correct for methods (results in bogus warning). bool SecondArgIsLastNamedArgument = false; if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Args[1])) { if (ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { diff --git a/Sema/SemaType.cpp b/Sema/SemaType.cpp index c89018a677..a9b8066f97 100644 --- a/Sema/SemaType.cpp +++ b/Sema/SemaType.cpp @@ -366,7 +366,7 @@ QualType Sema::ObjcGetTypeForMethodDefinition(DeclTy *D) { ArgTys.push_back(ArgTy); } T = Context.getFunctionType(T, &ArgTys[0], ArgTys.size(), - false); + MDecl->isVariadic()); return T; } diff --git a/test/Sema/va-method.m b/test/Sema/va-method.m new file mode 100644 index 0000000000..a8a7053043 --- /dev/null +++ b/test/Sema/va-method.m @@ -0,0 +1,17 @@ +// RUN: clang -fsyntax-only -verify %s + +#include <stdarg.h> + +@interface NSObject @end +@interface XX : NSObject @end + +@implementation XX +- (void)encodeValuesOfObjCTypes:(const char *)types, ... { + va_list ap; + va_start(ap, types); // expected-warning {{second parameter of 'va_start' not last named argument}} + while (*types) ; + va_end(ap); +} + +@end + |