diff options
author | Tanya Lattner <tonic@nondot.org> | 2013-04-04 23:45:52 +0000 |
---|---|---|
committer | Tanya Lattner <tonic@nondot.org> | 2013-04-04 23:45:52 +0000 |
commit | b0eb771fb5fcbbf283e357f95230adeb6570380f (patch) | |
tree | 1e26f33282f636908eda121e01e10d654246dd8d | |
parent | 98bb78885c36800d23fe247f10131bc6dcb30581 (diff) |
Revert 178811 until I fix the unit tests.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@178813 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | include/clang/Basic/DiagnosticSemaKinds.td | 4 | ||||
-rw-r--r-- | lib/Sema/SemaDecl.cpp | 10 | ||||
-rw-r--r-- | test/SemaOpenCL/event_t.cl | 2 | ||||
-rw-r--r-- | test/SemaOpenCL/storageclass.cl | 2 |
4 files changed, 2 insertions, 16 deletions
diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index fe8233b053..c4815cd7ea 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -6205,9 +6205,7 @@ def err_sampler_argument_required : Error< "sampler_t variable required - got %0">; def err_wrong_sampler_addressspace: Error< "sampler type cannot be used with the __local and __global address space qualifiers">; -def err_opencl_global_invalid_addr_space : Error< - "global variables must have a constant address space qualifier">; - + // OpenMP support. def err_omp_expected_var_arg_suggest : Error< "%0 is not a global variable, static local variable or static data member%select{|; did you mean %2?}1">; diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index e9116bc91a..adf3505633 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -5177,16 +5177,6 @@ bool Sema::CheckVariableDeclaration(VarDecl *NewVD, return false; } - // OpenCL v1.2 s6.5 - All program scope variables must be declared in the - // __constant address space. - if (getLangOpts().OpenCL && NewVD->isFileVarDecl() - && T.getAddressSpace() != LangAS::opencl_constant - && !T->isSamplerT()){ - Diag(NewVD->getLocation(), diag::err_opencl_global_invalid_addr_space); - NewVD->setInvalidDecl(); - return false; - } - // OpenCL v1.2 s6.8 -- The static qualifier is valid only in program // scope. if ((getLangOpts().OpenCLVersion >= 120) diff --git a/test/SemaOpenCL/event_t.cl b/test/SemaOpenCL/event_t.cl index 06197d0c17..57a0981cf1 100644 --- a/test/SemaOpenCL/event_t.cl +++ b/test/SemaOpenCL/event_t.cl @@ -2,7 +2,7 @@ event_t glb_evt; // expected-error {{the event_t type cannot be used to declare a program scope variable}} -constant struct evt_s { +struct evt_s { event_t evt; // expected-error {{the event_t type cannot be used to declare a structure or union field}} } evt_str; diff --git a/test/SemaOpenCL/storageclass.cl b/test/SemaOpenCL/storageclass.cl index d2678f2010..fdfe134621 100644 --- a/test/SemaOpenCL/storageclass.cl +++ b/test/SemaOpenCL/storageclass.cl @@ -2,8 +2,6 @@ static constant int A = 0; -int X = 0; // expected-error{{global variables must have a constant address space qualifier}} - // static is not allowed at local scope. void kernel foo() { static int X = 5; // expected-error{{variables in function scope cannot be declared static}} |