diff options
| author | Ted Kremenek <kremenek@apple.com> | 2008-07-03 15:37:02 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2008-07-03 15:37:02 +0000 |
| commit | aeca9637ce88da7f2ee7c0edba3d34f14a2c3015 (patch) | |
| tree | ff342d7d0ce30b98eb40c12404714321347a2e77 | |
| parent | a0fb5861dec7aa1da0d21d5759678d76b00464f4 (diff) | |
Skip the "-dealloc" check if a ObjC class contains no ivars.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@53100 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Analysis/CheckObjCDealloc.cpp | 9 | ||||
| -rw-r--r-- | test/Analysis/NSString.m | 4 |
2 files changed, 9 insertions, 4 deletions
diff --git a/lib/Analysis/CheckObjCDealloc.cpp b/lib/Analysis/CheckObjCDealloc.cpp index 38736dff3d..1f627216ef 100644 --- a/lib/Analysis/CheckObjCDealloc.cpp +++ b/lib/Analysis/CheckObjCDealloc.cpp @@ -47,10 +47,15 @@ void clang::CheckObjCDealloc(ObjCImplementationDecl* D, assert (LOpts.getGCMode() != LangOptions::GCOnly); ASTContext& Ctx = BR.getContext(); - + ObjCInterfaceDecl* ID = D->getClassInterface(); + + // Does the class contain any ivars? If not, skip the check entirely. + + if (ID->ivar_empty()) + return; + // Determine if the class subclasses NSObject. IdentifierInfo* NSObjectII = &Ctx.Idents.get("NSObject"); - ObjCInterfaceDecl* ID = D->getClassInterface(); for ( ; ID ; ID = ID->getSuperClass()) if (ID->getIdentifier() == NSObjectII) diff --git a/test/Analysis/NSString.m b/test/Analysis/NSString.m index 9a0b94ddca..a85a87aace 100644 --- a/test/Analysis/NSString.m +++ b/test/Analysis/NSString.m @@ -143,7 +143,7 @@ NSString* f10() { - (NSString*) getShared; + (C1*) sharedInstance; @end -@implementation C1 : NSObject {} // expected-warning{{Objective-C class 'C1' lacks a 'dealloc' instance method}} +@implementation C1 : NSObject {} - (NSString*) getShared { static NSString* s = 0; if (!s) s = [[NSString alloc] init]; @@ -161,7 +161,7 @@ NSString* f10() { @interface SharedClass : NSObject + (id)sharedInstance; @end -@implementation SharedClass // expected-warning {{Objective-C class 'SharedClass' lacks a 'dealloc' instance method}} +@implementation SharedClass - (id)_init { if ((self = [super init])) { |