aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteve Naroff <snaroff@apple.com>2008-02-10 01:39:04 +0000
committerSteve Naroff <snaroff@apple.com>2008-02-10 01:39:04 +0000
commitacb818a4f7d9b608826171094d6b5a555a8fe694 (patch)
tree7537bdd47dbeab2f8879870f2ed81cbaf9aa6a21
parent75ceedf377727cb39a4fbeb36f11462713b093f5 (diff)
Refine bug fix to Expr::isLvalue (commit r46917).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@46919 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--AST/Expr.cpp4
-rw-r--r--test/Sema/deref.c7
2 files changed, 10 insertions, 1 deletions
diff --git a/AST/Expr.cpp b/AST/Expr.cpp
index f979c7aa7b..00ff897ffb 100644
--- a/AST/Expr.cpp
+++ b/AST/Expr.cpp
@@ -357,6 +357,10 @@ Expr::isLvalueResult Expr::isLvalue() const {
if (TR->isFunctionType()) // from isObjectType()
return LV_NotObjectType;
+ // Allow qualified void which is an incomplete type other than void (yuck).
+ if (TR->isVoidType() && !TR.getQualifiers())
+ return LV_IncompleteVoidType;
+
if (TR->isReferenceType()) // C++ [expr]
return LV_Valid;
diff --git a/test/Sema/deref.c b/test/Sema/deref.c
index 7efb55e720..8f8156d81f 100644
--- a/test/Sema/deref.c
+++ b/test/Sema/deref.c
@@ -17,7 +17,7 @@ void foo2 (void)
void foo3 (void)
{
void* x = 0;
- void* y = &*x;
+ void* y = &*x; // expected-error{{address expression must be an lvalue or a function designator}}
}
extern const void cv1;
@@ -26,3 +26,8 @@ const void *foo4 (void)
return &cv1;
}
+extern void cv2;
+void *foo5 (void)
+{
+ return &cv2; // expected-error{{address expression must be an lvalue or a function designator}}
+}