diff options
| author | James Molloy <james.molloy@arm.com> | 2012-05-04 11:23:40 +0000 |
|---|---|---|
| committer | James Molloy <james.molloy@arm.com> | 2012-05-04 11:23:40 +0000 |
| commit | a30d8600b9b52922a92a90b30993564ba257537a (patch) | |
| tree | 47156886647d4e482c33bd4461d1a2b7799473f3 | |
| parent | 392da48160bd92ceb486792780467cbfdb2d0e8c (diff) | |
Add a predefine __WINT_UNSIGNED__, similar to __WCHAR_UNSIGNED__, and test them both for ARM and X86.
Use this to fully fix Sema/format-strings.c for non-x86 platforms.
Reviewed by Chandler on IRC.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156169 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Frontend/InitPreprocessor.cpp | 3 | ||||
| -rw-r--r-- | test/Lexer/wchar-signedness.c | 8 | ||||
| -rw-r--r-- | test/Sema/format-strings.c | 5 |
3 files changed, 16 insertions, 0 deletions
diff --git a/lib/Frontend/InitPreprocessor.cpp b/lib/Frontend/InitPreprocessor.cpp index 4df7cfd5be..3d9d1311c3 100644 --- a/lib/Frontend/InitPreprocessor.cpp +++ b/lib/Frontend/InitPreprocessor.cpp @@ -497,6 +497,9 @@ static void InitializePredefinedMacros(const TargetInfo &TI, if (!LangOpts.CharIsSigned) Builder.defineMacro("__CHAR_UNSIGNED__"); + if (!TargetInfo::isTypeSigned(TI.getWCharType())) + Builder.defineMacro("__WCHAR_UNSIGNED__"); + if (!TargetInfo::isTypeSigned(TI.getWIntType())) Builder.defineMacro("__WINT_UNSIGNED__"); diff --git a/test/Lexer/wchar-signedness.c b/test/Lexer/wchar-signedness.c new file mode 100644 index 0000000000..fea0ecac64 --- /dev/null +++ b/test/Lexer/wchar-signedness.c @@ -0,0 +1,8 @@ +// RUN: %clang_cc1 -fsyntax-only -dM -E %s -triple x86_64-none-linux-gnu | FileCheck %s --check-prefix=X86 +// RUN: %clang_cc1 -fsyntax-only -dM -E %s -triple armv7-none-eabi | FileCheck %s --check-prefix=ARM + +// CHECK-X86-NOT: #define __WCHAR_UNSIGNED__ +// CHECK-X86: #define __WINT_UNSIGNED__ 1 + +// CHECK-ARM: #define __WCHAR_UNSIGNED__ 1 +// CHECK-ARM-NOT: #define __WINT_UNSIGNED__ 1 diff --git a/test/Sema/format-strings.c b/test/Sema/format-strings.c index d1dca7e2fb..5d8e4cbb87 100644 --- a/test/Sema/format-strings.c +++ b/test/Sema/format-strings.c @@ -339,7 +339,12 @@ void pr7981(wint_t c, wchar_t c2) { printf("%lc", 1.0); // expected-warning{{the argument has type 'double'}} printf("%lc", (char) 1); // no-warning printf("%lc", &c); // expected-warning{{the argument has type 'wint_t *'}} + // If wint_t and wchar_t are the same width and wint_t is signed where + // wchar_t is unsigned, an implicit conversion isn't possible. +#if defined(__WINT_UNSIGNED__) || !defined(__WCHAR_UNSIGNED__) || \ + __WINT_WIDTH__ > __WCHAR_WIDTH__ printf("%lc", c2); // no-warning +#endif } // <rdar://problem/8269537> -Wformat-security says NULL is not a string literal |