diff options
| author | Ted Kremenek <kremenek@apple.com> | 2007-08-29 18:06:12 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2007-08-29 18:06:12 +0000 |
| commit | 9b3d3a9f3d60eff7b7c8d383203ff348527e3874 (patch) | |
| tree | 845341ec4d90a1482765ba55a4d324ac9944877f | |
| parent | d5bbce4382622feb4ca5978c4bb8fcceb7aaec00 (diff) | |
Added checking (during parsing) of comparison of floating point values using == or !=.
This is the same functionality gcc provides via --Wfloat-equal.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@41574 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | Sema/SemaExpr.cpp | 3 | ||||
| -rw-r--r-- | include/clang/Basic/DiagnosticKinds.def | 7 | ||||
| -rw-r--r-- | test/Sema/floating-point-compare.c | 9 |
3 files changed, 18 insertions, 1 deletions
diff --git a/Sema/SemaExpr.cpp b/Sema/SemaExpr.cpp index 9208db26a8..b613cd90a2 100644 --- a/Sema/SemaExpr.cpp +++ b/Sema/SemaExpr.cpp @@ -1157,6 +1157,9 @@ inline QualType Sema::CheckCompareOperands( // C99 6.5.8 if (lType->isRealType() && rType->isRealType()) return Context.IntTy; } else { + if (lType->isRealType() && rType->isRealType()) + Diag(loc, diag::warn_floatingpoint_eq); + if (lType->isArithmeticType() && rType->isArithmeticType()) return Context.IntTy; } diff --git a/include/clang/Basic/DiagnosticKinds.def b/include/clang/Basic/DiagnosticKinds.def index f2437d6554..8b1b1430e7 100644 --- a/include/clang/Basic/DiagnosticKinds.def +++ b/include/clang/Basic/DiagnosticKinds.def @@ -696,7 +696,7 @@ DIAG(err_typecheck_choose_expr_requires_constant, ERROR, DIAG(warn_unused_expr, WARNING, "expression result unused") -// Extra checking for finding simple bugs. +// CHECK: printf format string errors DIAG(warn_printf_not_string_constant, WARNING, "format string is not a string literal (potentially insecure)") DIAG(warn_printf_write_back, WARNING, @@ -716,11 +716,16 @@ DIAG(warn_printf_format_string_is_wide_literal, WARNING, DIAG(warn_printf_format_string_contains_null_char, WARNING, "format string contains '\\0' within the string body") +// CHECK: returning address/reference of stack memory DIAG(warn_ret_stack_addr, WARNING, "address of stack memory associated with local variable '%0' returned") DIAG(warn_ret_stack_ref, WARNING, "reference to stack memory associated with local variable '%0' returned") +// CHECK: floating point values should not use "==" or "!=" +DIAG(warn_floatingpoint_eq, WARNING, + "comparing floating point with == or != is unsafe") + // CFString checking DIAG(err_cfstring_literal_not_string_constant, ERROR, "CFString literal is not a string constant") diff --git a/test/Sema/floating-point-compare.c b/test/Sema/floating-point-compare.c new file mode 100644 index 0000000000..008bedf977 --- /dev/null +++ b/test/Sema/floating-point-compare.c @@ -0,0 +1,9 @@ +// RUN: clang -parse-ast-check %s + +int foo(float x, float y) { + return x == y; // expected-warning {{comparing floating point with ==}} +} + +int bar(float x, float y) { + return x != y; // expected-warning {{comparing floating point with ==}} +}
\ No newline at end of file |