diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2012-04-23 17:51:55 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2012-04-23 17:51:55 +0000 |
| commit | 923b0c93375db7e75a02bceb487f6f3d3da2766f (patch) | |
| tree | ec969ac904c9142a8cf070eebdc3373b14dcdd06 | |
| parent | ac28eca18a9f0a343c78ba90b02dfe52302c1f19 (diff) | |
Fix visibility when we have two types with explicit visibility in a template
argument list.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@155368 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/AST/Decl.cpp | 6 | ||||
| -rw-r--r-- | test/CodeGenCXX/visibility.cpp | 12 |
2 files changed, 15 insertions, 3 deletions
diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp index 77cc7a29b4..a98e8dddbb 100644 --- a/lib/AST/Decl.cpp +++ b/lib/AST/Decl.cpp @@ -122,7 +122,7 @@ static LinkageInfo getLVForTemplateArgumentList(const TemplateArgument *Args, break; case TemplateArgument::Type: - LV.merge(getLVForType(Args[I].getAsType())); + LV.mergeWithMin(getLVForType(Args[I].getAsType())); break; case TemplateArgument::Declaration: @@ -130,7 +130,7 @@ static LinkageInfo getLVForTemplateArgumentList(const TemplateArgument *Args, // arguments, valid only in C++0x. if (Decl *D = Args[I].getAsDecl()) { if (NamedDecl *ND = dyn_cast<NamedDecl>(D)) - LV.merge(getLVForDecl(ND, OnlyTemplate)); + LV.mergeWithMin(getLVForDecl(ND, OnlyTemplate)); } break; @@ -138,7 +138,7 @@ static LinkageInfo getLVForTemplateArgumentList(const TemplateArgument *Args, case TemplateArgument::TemplateExpansion: if (TemplateDecl *Template = Args[I].getAsTemplateOrTemplatePattern().getAsTemplateDecl()) - LV.merge(getLVForDecl(Template, OnlyTemplate)); + LV.mergeWithMin(getLVForDecl(Template, OnlyTemplate)); break; case TemplateArgument::Pack: diff --git a/test/CodeGenCXX/visibility.cpp b/test/CodeGenCXX/visibility.cpp index d126de3d05..2aa067886a 100644 --- a/test/CodeGenCXX/visibility.cpp +++ b/test/CodeGenCXX/visibility.cpp @@ -700,3 +700,15 @@ namespace test35 { // CHECK: define weak_odr void @_ZN6test353fooINS_3zedEE3barEv // CHECK-HIDDEN: define weak_odr void @_ZN6test353fooINS_3zedEE3barEv } + +namespace test36 { + template<typename T1, typename T2> + class foo { + void bar() {} + }; + class DEFAULT S1 {}; + struct HIDDEN S2 {}; + template class foo<S1, S2>; + // CHECK: define weak_odr hidden void @_ZN6test363fooINS_2S1ENS_2S2EE3barEv + // CHECK-HIDDEN: define weak_odr hidden void @_ZN6test363fooINS_2S1ENS_2S2EE3barEv +} |